Bug 60894 - Short-circuit NPRuntime calls made by Flash during plug-in instantiation
Summary: Short-circuit NPRuntime calls made by Flash during plug-in instantiation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-16 09:10 PDT by Anders Carlsson
Modified: 2011-05-16 09:34 PDT (History)
1 user (show)

See Also:

Attachments
Patch (10.15 KB, patch)
2011-05-16 09:17 PDT, Anders Carlsson 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-05-16 09:10:43 PDT 
Short-circuit NPRuntime calls made by Flash during plug-in instantiation
Comment 1 Anders Carlsson 2011-05-16 09:17:06 PDT 
Created attachment 93652 [details]
Patch
Comment 2 mitz 2011-05-16 09:29:10 PDT 
Comment on attachment 93652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93652&action=review

> Source/WebKit2/ChangeLog:13
> +        Since we know what calls Flash are making and what results are expected, we can handle the

Should this say “Flash is making”, since it says “Flash makes” in the first paragraph?

> Source/WebKit2/ChangeLog:31
> +        Check if the script string has the definitions of __flash_getWindowLocation or __flash_getTopLocation
> +        and just ignore them. Note that ignoring them has the effect of not adding them to the window object,

Can the functions still be added, asynchronously?
Comment 3 Anders Carlsson 2011-05-16 09:34:02 PDT 
(In reply to comment #2)
> (From update of attachment 93652 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=93652&action=review
> 
> > Source/WebKit2/ChangeLog:13
> > +        Since we know what calls Flash are making and what results are expected, we can handle the
> 
> Should this say “Flash is making”, since it says “Flash makes” in the first paragraph?
> 

Yes.

> > Source/WebKit2/ChangeLog:31
> > +        Check if the script string has the definitions of __flash_getWindowLocation or __flash_getTopLocation
> > +        and just ignore them. Note that ignoring them has the effect of not adding them to the window object,
> 
> Can the functions still be added, asynchronously?

Sure, but I don't think it's worth it. In the unlikely event that this is a problem we could re-evaluate (no pun intended) the decision.
Comment 4 Anders Carlsson 2011-05-16 09:34:15 PDT 
Committed r86578: <http://trac.webkit.org/changeset/86578>