WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
60894
Short-circuit NPRuntime calls made by Flash during plug-in instantiation
https://bugs.webkit.org/show_bug.cgi?id=60894
Summary
Short-circuit NPRuntime calls made by Flash during plug-in instantiation
Anders Carlsson
Reported
2011-05-16 09:10:43 PDT
Short-circuit NPRuntime calls made by Flash during plug-in instantiation
Attachments
Patch
(10.15 KB, patch)
2011-05-16 09:17 PDT
,
Anders Carlsson
oliver
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2011-05-16 09:17:06 PDT
Created
attachment 93652
[details]
Patch
mitz
Comment 2
2011-05-16 09:29:10 PDT
Comment on
attachment 93652
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=93652&action=review
> Source/WebKit2/ChangeLog:13 > + Since we know what calls Flash are making and what results are expected, we can handle the
Should this say “Flash is making”, since it says “Flash makes” in the first paragraph?
> Source/WebKit2/ChangeLog:31 > + Check if the script string has the definitions of __flash_getWindowLocation or __flash_getTopLocation > + and just ignore them. Note that ignoring them has the effect of not adding them to the window object,
Can the functions still be added, asynchronously?
Anders Carlsson
Comment 3
2011-05-16 09:34:02 PDT
(In reply to
comment #2
)
> (From update of
attachment 93652
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=93652&action=review
> > > Source/WebKit2/ChangeLog:13 > > + Since we know what calls Flash are making and what results are expected, we can handle the > > Should this say “Flash is making”, since it says “Flash makes” in the first paragraph? >
Yes.
> > Source/WebKit2/ChangeLog:31 > > + Check if the script string has the definitions of __flash_getWindowLocation or __flash_getTopLocation > > + and just ignore them. Note that ignoring them has the effect of not adding them to the window object, > > Can the functions still be added, asynchronously?
Sure, but I don't think it's worth it. In the unlikely event that this is a problem we could re-evaluate (no pun intended) the decision.
Anders Carlsson
Comment 4
2011-05-16 09:34:15 PDT
Committed
r86578
: <
http://trac.webkit.org/changeset/86578
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug