Bug 60894 – Short-circuit NPRuntime calls made by Flash during plug-in instantiation

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Short-circuit NPRuntime calls made by Flash during plug-in instantiation

[Anders Carlsson]

Created attachment 93652 [details]
Patch

Comment on attachment 93652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93652&action=review

> Source/WebKit2/ChangeLog:13
> +        Since we know what calls Flash are making and what results are expected, we can handle the

Should this say “Flash is making”, since it says “Flash makes” in the first paragraph?

> Source/WebKit2/ChangeLog:31
> +        Check if the script string has the definitions of __flash_getWindowLocation or __flash_getTopLocation
> +        and just ignore them. Note that ignoring them has the effect of not adding them to the window object,

Can the functions still be added, asynchronously?

[Anders Carlsson]

(In reply to comment #2)
> (From update of attachment 93652 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=93652&action=review
> 
> > Source/WebKit2/ChangeLog:13
> > +        Since we know what calls Flash are making and what results are expected, we can handle the
> 
> Should this say “Flash is making”, since it says “Flash makes” in the first paragraph?
> 

Yes.

> > Source/WebKit2/ChangeLog:31
> > +        Check if the script string has the definitions of __flash_getWindowLocation or __flash_getTopLocation
> > +        and just ignore them. Note that ignoring them has the effect of not adding them to the window object,
> 
> Can the functions still be added, asynchronously?

Sure, but I don't think it's worth it. In the unlikely event that this is a problem we could re-evaluate (no pun intended) the decision.

[Anders Carlsson]

Committed r86578: <http://trac.webkit.org/changeset/86578>