Bug 60892 - REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphicsWebView
Summary: REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphics...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Andreas Kling
Keywords: Qt, QtTriaged
Depends on:
Reported: 2011-05-16 09:02 PDT by Andreas Kling
Modified: 2011-05-16 14:05 PDT (History)
4 users (show)

See Also:

Proposed patch (1.56 KB, patch)
2011-05-16 09:12 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-05-16 09:02:41 PDT
In r83820, an extra GraphicsLayer was added to the RenderLayerCompositor to contain all other layers, including the new scroll bar layers. The layer never gets a size set, since it's merely a container. This breaks PageClientQGraphicsWidget's assumption that the outermost layer should clip its children. This is already handled by the RenderLayerCompositor's "clip layer."
Comment 1 Andreas Kling 2011-05-16 09:12:54 PDT
Created attachment 93651 [details]
Proposed patch
Comment 2 Kenneth Rohde Christiansen 2011-05-16 09:46:08 PDT
Comment on attachment 93651 [details]
Proposed patch

Good find! :-)
Comment 3 Andreas Kling 2011-05-16 10:10:03 PDT
Comment on attachment 93651 [details]
Proposed patch

Clearing flags on attachment: 93651

Committed r86582: <http://trac.webkit.org/changeset/86582>
Comment 4 Andreas Kling 2011-05-16 10:10:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Antonio Gomes 2011-05-16 10:50:46 PDT
Is there a way to catch such regressions?
Comment 6 Ademar Reis 2011-05-16 14:05:00 PDT
Revision r86582 cherry-picked into qtwebkit-2.2 with commit 816a9ab <http://gitorious.org/webkit/qtwebkit/commit/816a9ab>