Bug 60888 - Web Inspector: debuggerWasEnabled notification should not be send to frontend on navigation.
Summary: Web Inspector: debuggerWasEnabled notification should not be send to frontend...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-16 08:14 PDT by Pavel Podivilov
Modified: 2011-05-16 10:04 PDT (History)
10 users (show)

See Also:


Attachments
Patch. (5.93 KB, patch)
2011-05-16 08:15 PDT, Pavel Podivilov
yurys: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-05-16 08:14:56 PDT
Web Inspector: debuggerWasEnabled notification should not be send to frontend on navigation.
Comment 1 Pavel Podivilov 2011-05-16 08:15:26 PDT
Created attachment 93645 [details]
Patch.
Comment 2 Yury Semikhatsky 2011-05-16 08:23:19 PDT
Comment on attachment 93645 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=93645&action=review

> Source/WebCore/inspector/InspectorController.h:-118
> -    void disableDebugger();

Please make sure this doesn't break Safari. I only see Start debugging... but please double check.

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:144
> +    m_inspectorState->setBoolean(DebuggerAgentState::debuggerEnabled, false);

After front-end reopening debugger will be off in Safari. r- for this.
Comment 3 Yury Semikhatsky 2011-05-16 08:24:56 PDT
(In reply to comment #2)
> After front-end reopening debugger will be off in Safari. r- for this.
Sorry, of cause it will be restored from the local store on the front-end and pushed to the back end.
Comment 4 WebKit Review Bot 2011-05-16 08:25:27 PDT
Comment on attachment 93645 [details]
Patch.

Attachment 93645 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8699878
Comment 5 Early Warning System Bot 2011-05-16 08:27:45 PDT
Comment on attachment 93645 [details]
Patch.

Attachment 93645 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8704015
Comment 6 Pavel Podivilov 2011-05-16 10:04:46 PDT
Committed r86581: <http://trac.webkit.org/changeset/86581>