Bug 60887 – [Qt][Wk2][Symbian] Fix build after r86560

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Siddharth Mathur]

In Bug 55875, we started using USE(UNIX_DOMAIN_SOCKETS) to guard Qt-Unix and Gtk code which uses code dependent on Unix domain socket IPC. 
r86560 (http://trac.webkit.org/changeset/86560) should have guarded ArgumentDecoder.cpp and ArgumentEncoder.cpp too, otherwise Qt-Symbian build breaks.

[Siddharth Mathur]

Created attachment 93644 [details]
build fix for Symbian buildbot

Fixes build failure: http://build.webkit.sed.hu/builders/Qt%20Symbian%20ARMv5%20Release/builds/1044/steps/compile%20Source/logs/stdio

[Csaba Osztrogonác]

Comment on attachment 93644 [details]
build fix for Symbian buildbot

View in context: https://bugs.webkit.org/attachment.cgi?id=93644&action=review

> Source/WebKit2/ChangeLog:10
> +        (CoreIPC::ArgumentDecoder::~ArgumentDecoder): guard Unix and Gtk code with HAVE(UNIX_DOMAIN_SOCKETS)
> +        * Platform/CoreIPC/ArgumentEncoder.cpp:

r=me with change HAVE to USE.
Please fix it before landing.

[Csaba Osztrogonác]

Landed in http://trac.webkit.org/changeset/86574

[Siddharth Mathur]

Build still busted, re-opening

[Siddharth Mathur]

Created attachment 93663 [details]
try 2: build fix for Symbian buildbot

Balazs had moved some of key QT||GTK defines to UNIX_DOMAIN_SOCKET guards, so I was caught off guard. My bad. 
My intention was to land Symbian parts in separate Bug 55875 (Shared Memory) and Bug 55877 (Core IPC and Process launching) 

In any case, here is a somewhat hacky middle ground to keep Symbian bot green until I re-baseline the Core IPC patch in Bug 55877 and get it landed.

[Csaba Osztrogonác]

Comment on attachment 93663 [details]
try 2: build fix for Symbian buildbot

It is a little bit ugly workaround, but rs=me until the real fix landed.

[Csaba Osztrogonác]

I landed it manually after I removed the unnecessarz trailing whitespaces: http://trac.webkit.org/changeset/86585