Bug 60886 - Add the ability for a plug-in controller to short-circuit calls to NPN_Invoke
Summary: Add the ability for a plug-in controller to short-circuit calls to NPN_Invoke
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-16 08:05 PDT by Anders Carlsson
Modified: 2011-05-16 08:11 PDT (History)
0 users

See Also:

Attachments
Patch (9.00 KB, patch)
2011-05-16 08:08 PDT, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-05-16 08:05:12 PDT 
Add the ability for a plug-in controller to short-circuit calls to NPN_Invoke
Comment 1 Anders Carlsson 2011-05-16 08:08:55 PDT 
Created attachment 93643 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-05-16 08:10:57 PDT 
Comment on attachment 93643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93643&action=review

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:284
> +bool PluginControllerProxy::tryToShortCircuitInvoke(NPObject*, NPIdentifier methodName, const NPVariant* arguments, uint32_t argumentCount, NPVariant* result)

Will these unused variables be a problem?

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:543
> +bool PluginControllerProxy::tryToShortCircuitEvaluate(NPObject* npObject, const String& scriptString, NPVariant* result)

Will these unused variables be a problem?
Comment 3 Anders Carlsson 2011-05-16 08:11:51 PDT 
Committed r86573: <http://trac.webkit.org/changeset/86573>