RESOLVED FIXED 60876
commit-queue does not accept new reviewers 
https://bugs.webkit.org/show_bug.cgi?id=60876
Summary commit-queue does not accept new reviewers
Patrick R. Gansterer
Reported 2011-05-16 01:33:51 PDT
see bug 59905 (morrita is a reviewer, but cq does not accept the reviewed patch)
Attachments
Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-05-16 01:42:53 PDT
Here's what the bot says: [[ - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. ]] Did you try those things?
Patrick R. Gansterer
Comment 2 2011-05-16 01:45:26 PDT
(In reply to comment #1) > Here's what the bot says: > > [[ > - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. > ]] > > Did you try those things? I can read. :) See http://trac.webkit.org/changeset/86210/trunk/Tools/Scripts/webkitpy/common/config/committers.py. The change is older than 5 days.
Adam Barth
Comment 3 2011-05-16 02:06:39 PDT
Five days... That does seem like a long time.
Eric Seidel (no email)
Comment 4 2011-05-16 11:08:00 PDT
Maybe the feeder-queue got started without the wrapper script? Adam? The feeder-queue is the one who deals with rejects these days.
Adam Barth
Comment 5 2011-05-16 11:16:16 PDT
The feeder queue was blocked from updating its working copy because of its dependency on git.webkit.org, which is unreliable.
Eric Seidel (no email)
Comment 6 2011-09-16 16:19:15 PDT
We believe this to be resolved. Please re-open if you disagree. :)
Note You need to log in before you can comment on or make changes to this bug.