Bug 60873 - [Qt] QtPlatformPlugin create methods should use PassOwnPtr
Summary: [Qt] QtPlatformPlugin create methods should use PassOwnPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-16 00:05 PDT by Adam Barth
Modified: 2011-05-16 00:24 PDT (History)
1 user (show)

See Also:

Attachments
Patch (15.65 KB, patch)
2011-05-16 00:23 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-05-16 00:05:15 PDT 
The "create" methods of QtPlatformPlugin allocate memory and pass ownership of the created object.  Therefore, they should return PassOwnPtrs instead of raw pointers.  That would let use get rid a bunch of manual calls to delete.
Comment 1 Adam Barth 2011-05-16 00:23:38 PDT 
Created attachment 93617 [details]
Patch
Comment 2 Adam Barth 2011-05-16 00:24:06 PDT 
Committed r86537: <http://trac.webkit.org/changeset/86537>