Bug 60867 - Enable strict mode for OwnPtr and PassOwnPtr
Summary: Enable strict mode for OwnPtr and PassOwnPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Naiem
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-15 19:35 PDT by Naiem
Modified: 2011-05-16 05:09 PDT (History)
3 users (show)

See Also:


Attachments
patch for fixing the build break (3.56 KB, patch)
2011-05-16 01:43 PDT, Naiem
no flags Details | Formatted Diff | Diff
incorporated review comments (3.96 KB, patch)
2011-05-16 02:40 PDT, Naiem
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Naiem 2011-05-15 19:35:57 PDT
Need to Enable strict mode for OwnPtr and PassOwnPtr inside GraphicsContext3DGtk class
Comment 1 Naiem 2011-05-16 01:43:51 PDT
Created attachment 93623 [details]
patch for fixing the build break

This is for removing the dependency on LOOSE_OWN_PTR
Comment 2 Adam Barth 2011-05-16 01:50:56 PDT
Comment on attachment 93623 [details]
patch for fixing the build break

View in context: https://bugs.webkit.org/attachment.cgi?id=93623&action=review

> Source/WebCore/platform/graphics/gtk/GraphicsContext3DGtk.cpp:31
> +#include "PassOwnPtr.h"

This should be

#include <wtf/PassOwnPtr.h>

> Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.cpp:21
> +#include "PassOwnPtr.h"

This should be

#include <wtf/PassOwnPtr.h>

> Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.cpp:94
>          return 0;

This should be "return nullptr" or else it will break soon again.  (The same applies to the other instances of "return 0" in this function.)
Comment 3 Naiem 2011-05-16 02:40:00 PDT
Created attachment 93629 [details]
incorporated review comments

incorporating review comments
Comment 4 WebKit Commit Bot 2011-05-16 04:41:22 PDT
Comment on attachment 93629 [details]
incorporated review comments

Rejecting attachment 93629 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-a..." exit_code: 1

Last 500 characters of output:
autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://queues.webkit.org/results/8694985
Comment 5 Andras Becsi 2011-05-16 05:08:07 PDT
Landed in http://trac.webkit.org/changeset/86557.
Comment 6 Andras Becsi 2011-05-16 05:08:47 PDT
Comment on attachment 93623 [details]
patch for fixing the build break

Clearing flags from obsolete patch.
Comment 7 Andras Becsi 2011-05-16 05:09:12 PDT
Comment on attachment 93629 [details]
incorporated review comments

Clearing flags from landed patch.