Bug 60867 – Enable strict mode for OwnPtr and PassOwnPtr

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Naiem]

Need to Enable strict mode for OwnPtr and PassOwnPtr inside GraphicsContext3DGtk class

[Naiem]

Created attachment 93623 [details]
patch for fixing the build break

This is for removing the dependency on LOOSE_OWN_PTR

[Adam Barth]

Comment on attachment 93623 [details]
patch for fixing the build break

View in context: https://bugs.webkit.org/attachment.cgi?id=93623&action=review

> Source/WebCore/platform/graphics/gtk/GraphicsContext3DGtk.cpp:31
> +#include "PassOwnPtr.h"

This should be

#include <wtf/PassOwnPtr.h>

> Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.cpp:21
> +#include "PassOwnPtr.h"

This should be

#include <wtf/PassOwnPtr.h>

> Source/WebCore/platform/graphics/gtk/GraphicsContext3DInternal.cpp:94
>          return 0;

This should be "return nullptr" or else it will break soon again.  (The same applies to the other instances of "return 0" in this function.)

[Naiem]

Created attachment 93629 [details]
incorporated review comments

incorporating review comments

[WebKit Commit Bot]

Comment on attachment 93629 [details]
incorporated review comments

Rejecting attachment 93629 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-a..." exit_code: 1

Last 500 characters of output:
autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://queues.webkit.org/results/8694985

[Andras Becsi]

Landed in http://trac.webkit.org/changeset/86557.

[Andras Becsi]

Comment on attachment 93623 [details]
patch for fixing the build break

Clearing flags from obsolete patch.

[Andras Becsi]

Comment on attachment 93629 [details]
incorporated review comments

Clearing flags from landed patch.