Bug 60859 - Make API tester more gtest friendly
Summary: Make API tester more gtest friendly
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
Depends on:
Reported: 2011-05-15 14:50 PDT by Sam Weinig
Modified: 2011-05-15 15:41 PDT (History)
1 user (show)

See Also:

Patch (11.46 KB, patch)
2011-05-15 14:56 PDT, Sam Weinig
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-05-15 14:50:38 PDT
Make API tester more gtest friendly
Comment 1 Sam Weinig 2011-05-15 14:56:16 PDT
Created attachment 93590 [details]
Comment 2 Sam Weinig 2011-05-15 14:59:09 PDT
With this patch, the output of run-api-tests is the standard gtest output (which I am not particularly fond of, but that is neither here nor there) and you can easily pass gtest command line arguments to the tool just by passing them on the command line (eg. run-api-tests --gtest_output="xml").  This gives us a nicer place to improve from.
Comment 3 David Levin 2011-05-15 15:38:39 PDT
Comment on attachment 93590 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=93590&action=review


> Tools/Scripts/run-api-tests:94
> +            $childOut = ">&STDOUT";

You could even move out out of the unless/else, since it is now common between the two clauses.
Comment 4 Sam Weinig 2011-05-15 15:41:26 PDT
Committed r86511: <http://trac.webkit.org/changeset/86511>