Bug 60858 - [Qt] Fix crash in inspector/console/console-long-eval-crash.html
Summary: [Qt] Fix crash in inspector/console/console-long-eval-crash.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-15 13:14 PDT by Robert Hogan
Modified: 2011-05-16 02:51 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.52 KB, patch)
2011-05-15 13:25 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2011-05-15 13:14:10 PDT 
[Qt] Fix crash in inspector/console/console-long-eval-crash.html
Comment 1 Robert Hogan 2011-05-15 13:25:20 PDT 
Created attachment 93589 [details]
Patch
Comment 2 Robert Hogan 2011-05-15 13:27:54 PDT 
Hi Ilya,

Does this look right to you? Or maybe there was a good reason for not protecting the call to m_client in sendMessageToBackend() ?
Comment 3 Ilya Tikhonovsky 2011-05-15 14:12:29 PDT 
looks good to me
Comment 4 Yury Semikhatsky 2011-05-16 00:12:41 PDT 
Comment on attachment 93589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93589&action=review

> Source/WebCore/inspector/InspectorFrontendHost.cpp:246
> +          m_client->sendMessageToBackend(message);

style: wrong alignment, not sure why style-check did fail.
Comment 5 Ilya Tikhonovsky 2011-05-16 02:51:23 PDT 
manually Committed r86551