WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
60848
svn-{apply, unapply} can't handle Git diff that only changes executable bit
https://bugs.webkit.org/show_bug.cgi?id=60848
Summary
svn-{apply, unapply} can't handle Git diff that only changes executable bit
Daniel Bates
Reported
2011-05-14 15:44:20 PDT
The patch <
https://bugs.webkit.org/attachment.cgi?id=90852
> failed to apply since it contains a diff that only changes the executable bit of a file, Tools/Scripts/run-gtk-tests. svn-{apply, unapply} can handle the SVN equivalent of this, an SVN property change diff for a file that only has property changes, since it follows naturally from the presence of an SVN property change header (because property changes are separated from content changes in an SVN patch). Git outputs one diff header per file that may include, among other things, file mode information; content changes; or both. We should teach svn-{apply, unapply} how to handle a diff that only changes the executable bit of a file.
Attachments
Patch and unit tests
(14.19 KB, patch)
2011-05-14 15:47 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2011-05-14 15:47:52 PDT
Created
attachment 93572
[details]
Patch and unit tests
Daniel Bates
Comment 2
2011-05-15 16:55:16 PDT
Committed
r86515
: <
http://trac.webkit.org/changeset/86515
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug