Bug 60830 – Mouse-select then Cut, results in preceding character being lost

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[PAC]

Initially reported as a Chromium bug, I have been asked to post to webkit buglist....

Chrome Version       : 11.0.696.68
OS Version: OS X 10.6.7
Other browsers tested:
    Safari 5.0.5 (6533.21.1):  FAIL
    Chromium 11.0.692.0 (77020): FAIL
    Firefox 4.x: OK

What steps will reproduce the problem?

1. Load any webpage with a <TEXTAREA>, lets use http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_textarea
2. Using the mouse, double click any word. Lets use 'because' as an example..
3. Press CMD-X to cut
3. Press CMD-V to paste it back again

What is the expected result?

'because' is cut into the clipboard, leaving the rest of the text intact
Pasting the word back should result in the original text again

What happens instead?

'because' is cut into the clipboard, but the preceding character (in this case a space) disappears completely (and isnt in clipboard). 
This happens no matter what the preceding character is, even if its a carriage return.

The same problem does *not* occur if you use the keyboard to select the word, and then cut.

[Mehmet]

Chromium Bug-Report: http://code.google.com/p/chromium/issues/detail?id=82603

[Alexey Proskuryakov]

> 'because' is cut into the clipboard, leaving the rest of the text intact

Why do you expect that? It's intentional that extra spaces are removed, it's called "smart cut&paste". TextEdit has the same behavior.

> Pasting the word back should result in the original text again

Here, WebKit clearly has a bug. Pasting should be smart too!

[Sukolsak Sakshuwong]

Created attachment 157351 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 157351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157351&action=review

> LayoutTests/editing/pasteboard/smart-paste-in-text-control-expected.txt:3
> +Hello world test

It's not obvious when the test is passing. Can we print out PASS/FAIL based on the results?

> LayoutTests/editing/pasteboard/smart-paste-in-text-control.html:14
> +This tests smart pasting in a text control. There are three words in the text area below, i.e. "Hello world test". We double click the middle word. Then we cut and paste. It should result in the original text. The space before the middle word should not be lost.

You probably want to split this into two lines.
We normally mention the part for manual testing by "To manually test, ~~".

[Sukolsak Sakshuwong]

Created attachment 157359 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 157359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157359&action=review

> Source/WebCore/platform/mac/ClipboardMac.mm:387
> +    pasteboard.writePlainText(text, false);

Ugh... can we use enum instead so that these call sites don't look so cryptic?

[Sukolsak Sakshuwong]

Created attachment 157569 [details]
Patch

[WebKit Review Bot]

Comment on attachment 157569 [details]
Patch

Clearing flags on attachment: 157569

Committed r125247: <http://trac.webkit.org/changeset/125247>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.