WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
60826
Video is blank, controller is misplaced on trailers.apple.com movie in fullscreen (with two screens)
https://bugs.webkit.org/show_bug.cgi?id=60826
Summary
Video is blank, controller is misplaced on trailers.apple.com movie in fullsc...
Jer Noble
Reported
2011-05-13 19:51:38 PDT
Video is blank, controller is misplaced on trailers.apple.com movie in fullscreen (with two screens)
Attachments
Patch
(12.61 KB, patch)
2011-05-13 19:54 PDT
,
Jer Noble
simon.fraser
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jer Noble
Comment 1
2011-05-13 19:54:28 PDT
Created
attachment 93544
[details]
Patch
Simon Fraser (smfr)
Comment 2
2011-05-13 20:09:09 PDT
Comment on
attachment 93544
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=93544&action=review
> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1238 > + PlatformLayer* layer = m_qtVideoLayer.get(); > + do { > + if (rootLayer != layer) > + continue; > + > + // We own a child layer of a layer which has switched contexts. > + // Tear down our layer, and set m_visible to false, so that the > + // next time setVisible(true) is called, the layer will be re- > + // created in the correct context. > + tearDownVideoRendering(); > + m_visible = false; > + break; > + } while((layer = [layer superlayer]));
This code is confusing. I think you want to have a loop that walks up the tree, and to pull the tearDownVideoRendering() code out of the loop.
> Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:145 > + [[NSNotificationCenter defaultCenter] postNotificationName:@"CAContextChanged" object:nil userInfo:[NSDictionary dictionaryWithObject:m_fullScreenRootLayer.get() forKey:@"RootLayer"]]; > + m_fullScreenRootLayer = 0;
You should add a comment to say who listens for this notification. I also think you should use a more unique name than "CAContextChanged", since it would be easy to imagine CA adding a notification with the same name in future.
Jer Noble
Comment 3
2011-05-16 10:51:07 PDT
Committed
r86588
: <
http://trac.webkit.org/changeset/86588
>
Ademar Reis
Comment 4
2011-06-03 14:06:58 PDT
Revision
r86588
cherry-picked into qtwebkit-2.2 with commit 9f2e6b1 <
http://gitorious.org/webkit/qtwebkit/commit/9f2e6b1
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug