Bug 60811 - Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
Summary: Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-05-13 15:16 PDT by Pavel Feldman
Modified: 2011-05-19 11:53 PDT (History)
10 users (show)

See Also:

Attachments
Patch (8.70 KB, patch)
2011-05-18 07:24 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (9.97 KB, patch)
2011-05-18 08:28 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (10.00 KB, patch)
2011-05-18 08:33 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-05-13 15:16:39 PDT 
I thought we had a test for this one. Surprised it does not work.
Comment 1 Pavel Feldman 2011-05-18 07:24:09 PDT 
Created attachment 93910 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2011-05-18 07:28:14 PDT 
Comment on attachment 93910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93910&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:378
> +    selectedCallFrameVariables: function()

Any reason for this not being a getter?
Comment 3 Yury Semikhatsky 2011-05-18 07:45:01 PDT 
Comment on attachment 93910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93910&action=review

> LayoutTests/inspector/debugger/debugger-completions-on-call-frame.html:30
> +                InspectorTest.addResult(golden[i]);

Would be better to addResult("FAIL") in case of missing property.

> Source/WebCore/inspector/InjectedScriptSource.js:484
> +            for (var name in scopeChain[i])

This will be too slow for global scope.

> Source/WebCore/inspector/InjectedScriptSource.js:497
> +        for (var name in scopeVariableNames)

I'd rather resurrect the command that allowed to quickly request all completions.
Comment 4 Pavel Feldman 2011-05-18 08:28:18 PDT 
Created attachment 93918 [details]
Patch
Comment 5 Pavel Feldman 2011-05-18 08:33:54 PDT 
Created attachment 93920 [details]
Patch
Comment 6 Pavel Feldman 2011-05-18 08:53:09 PDT 
Comment on attachment 93920 [details]
Patch

Clearing flags on attachment: 93920

Committed r86768: <http://trac.webkit.org/changeset/86768>
Comment 7 Pavel Feldman 2011-05-18 08:53:18 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Alexey Proskuryakov 2011-05-19 11:53:18 PDT 
<rdar://problem/9470349>