Bug 60797 – Fix regressions from r86447

• Status: RESOLVED
• Resolution: INVALID
• Component: New Bugs

[Robert Hogan]

Fix regressions from r86447

[Robert Hogan]

Created attachment 93501 [details]
Patch

[Benjamin Poulain]

Comment on attachment 93501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93501&action=review

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:177
> +        m_eventSenderWebView = new QWebView(0);

This view is leaked.

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:1121
> +    // that is just enough to allow EventSender to install an event filter.
> +    // We use a new (dummy) QWebView so that we don't interfere
> +    // with the EventSender on the main page.
> +    DumpRenderTreeSupportQt::setView(page, static_cast<WebPage*>(page)->eventSenderWebView());

I guess you could simply create the view here, so you can use the container for handling the memory.

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.h:187
> +    QWebView* eventSenderWebView();

This is not really the event sender WebView, it is just the main view of the page. I would rather have a name that does not mention eventSender.

[Robert Hogan]

Created attachment 93506 [details]
Patch

[Benjamin Poulain]

Comment on attachment 93506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93506&action=review

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:1114
> +    QWebView* view = new QWebView(0);

leak :)