Bug 60788 - REGRESSION (r69790): WebKit2 doesn't prefer plugins in the additional plugins directory
Summary: REGRESSION (r69790): WebKit2 doesn't prefer plugins in the additional plugins...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2011-05-13 12:43 PDT by Adam Roben (:aroben)
Modified: 2011-05-13 12:55 PDT (History)
1 user (show)

See Also:

Attachments
Load plugins in the order they're found (1.97 KB, patch)
2011-05-13 12:46 PDT, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-05-13 12:43:11 PDT 
Prior to r69790, WebKit2 would prefer plugins in the additional plugins directory to any other plugins (if two plugins claim the same MIME type). r69760 broke that by making plugins load in an essentially random order.
Comment 1 Adam Roben (:aroben) 2011-05-13 12:46:43 PDT 
Created attachment 93494 [details]
Load plugins in the order they're found
Comment 2 Anders Carlsson 2011-05-13 12:47:39 PDT 
Comment on attachment 93494 [details]
Load plugins in the order they're found

View in context: https://bugs.webkit.org/attachment.cgi?id=93494&action=review

> Source/WebKit2/UIProcess/Plugins/PluginInfoStore.cpp:67
>  #if OS(WINDOWS)
> -typedef HashSet<String, CaseFoldingHash> PathHashSet;
> +typedef ListHashSet<String, 32, CaseFoldingHash> PathHashSet;
>  #else
> -typedef HashSet<String> PathHashSet;
> +typedef ListHashSet<String, 32> PathHashSet;
>  #endif

Please add a comment here explaining why wer're using a ListHashSet.
Comment 3 Adam Roben (:aroben) 2011-05-13 12:48:01 PDT 
<rdar://problem/9435787>
Comment 4 Adam Roben (:aroben) 2011-05-13 12:55:24 PDT 
Committed r86456: <http://trac.webkit.org/changeset/86456>