Bug 60775 - Source/WebCore/html/HTMLFrameElementBase.cpp contains unecessary includes
Summary: Source/WebCore/html/HTMLFrameElementBase.cpp contains unecessary includes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-13 09:10 PDT by arno.
Modified: 2011-05-15 04:40 PDT (History)
5 users (show)

See Also:

Attachments
patch v1 (1.43 KB, patch)
2011-05-13 09:31 PDT, arno. 		no flags Details | Formatted Diff | Diff
patch v1.1 (1.38 KB, patch)
2011-05-13 10:29 PDT, arno. 		no flags Details | Formatted Diff | Diff
patch v1.2 (1.42 KB, patch)
2011-05-15 00:42 PDT, arno. 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description arno. 2011-05-13 09:10:20 PDT 
Hi,
in HTMLFrameElementBase.cpp, there are some includes wich seem to be not needed in that file (for example RenderEmbeddedObject.h or HTMLFrameSetElement.h)
Comment 1 arno. 2011-05-13 09:31:43 PDT 
Created attachment 93465 [details]
patch v1

I checked included files, and removed those who looked unused. In order to build webkit, I had to include back SubFrameLoader.h and RenderPart.h. They were probably included by some of the removed includes
Comment 2 Early Warning System Bot 2011-05-13 09:41:09 PDT 
Comment on attachment 93465 [details]
patch v1

Attachment 93465 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8693220
Comment 3 WebKit Review Bot 2011-05-13 10:05:22 PDT 
Comment on attachment 93465 [details]
patch v1

Attachment 93465 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8695153
Comment 4 Gustavo Noronha (kov) 2011-05-13 10:24:51 PDT 
Comment on attachment 93465 [details]
patch v1

Attachment 93465 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8693230
Comment 5 arno. 2011-05-13 10:29:50 PDT 
Created attachment 93477 [details]
patch v1.1

I probably need to let FrameLoader.h
Comment 6 WebKit Commit Bot 2011-05-14 14:56:17 PDT 
Comment on attachment 93477 [details]
patch v1.1

Rejecting attachment 93477 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'la..." exit_code: 2

Last 500 characters of output:
.org/WebKit
   ff67c13..aa00ad0  master     -> origin/master
	M	Source/WebKit2/ChangeLog
	M	Source/WebKit2/UIProcess/mac/TextCheckerMac.mm
r86497 = 3e84409c598e09da7b74f2e08d0a2685f245c2f5 (refs/remotes/trunk)
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/bridge/qt/qt_runtime.cpp
	M	Source/WebCore/bridge/qt/qt_runtime.h
r86498 = aa00ad0c35bfe0bda94a6e7700e12142fcb99ae7 (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded new_master to refs/remotes/trunk.

Full output: http://queues.webkit.org/results/8698438
Comment 7 Adam Barth 2011-05-14 15:28:38 PDT 
Comment on attachment 93477 [details]
patch v1.1

View in context: https://bugs.webkit.org/attachment.cgi?id=93477&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

This line is preventing the patch from landing.  You should replace this line with a sentence about how you're not changing functionality.
Comment 8 arno. 2011-05-15 00:42:07 PDT 
Created attachment 93576 [details]
patch v1.2
Comment 9 Eric Seidel (no email) 2011-05-15 01:23:28 PDT 
Comment on attachment 93576 [details]
patch v1.2

OK.
Comment 10 WebKit Commit Bot 2011-05-15 04:40:10 PDT 
Comment on attachment 93576 [details]
patch v1.2

Clearing flags on attachment: 93576

Committed r86503: <http://trac.webkit.org/changeset/86503>
Comment 11 WebKit Commit Bot 2011-05-15 04:40:16 PDT 
All reviewed patches have been landed.  Closing bug.