Bug 60768 - Port Mozilla's IndexedDB tests: remove objectstore
Summary: Port Mozilla's IndexedDB tests: remove objectstore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-13 07:19 PDT by Mark Pilgrim (Google)
Modified: 2011-05-13 15:32 PDT (History)
6 users (show)

See Also:


Attachments
Patch (10.51 KB, patch)
2011-05-13 07:21 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2011-05-13 07:19:12 PDT
Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_remove_objectStore.html?force=1

This is a port of a test from Mozilla's IndexedDB test suite. It creates an objectstore, populates it with 100 records, deletes the objectstore, and checks that the objectStoreNames array is updated properly at each step.

WebKit passes this test.
Comment 1 Mark Pilgrim (Google) 2011-05-13 07:21:20 PDT
Created attachment 93448 [details]
Patch
Comment 2 David Grogan 2011-05-13 14:03:18 PDT
Comment on attachment 93448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93448&action=review

unofficial r+

> LayoutTests/storage/indexeddb/mozilla/remove-objectstore.html:89
> +        shouldBe("event.target.result", "null");

Is the result of opening the cursor null because nothing is in the objectStore or because you didn't seek to anything (which would also return null in this case)?
Comment 3 Mark Pilgrim (Google) 2011-05-13 14:24:24 PDT
Because nothing is in the object store.
Comment 4 WebKit Commit Bot 2011-05-13 15:32:30 PDT
Comment on attachment 93448 [details]
Patch

Clearing flags on attachment: 93448

Committed r86466: <http://trac.webkit.org/changeset/86466>
Comment 5 WebKit Commit Bot 2011-05-13 15:32:35 PDT
All reviewed patches have been landed.  Closing bug.