Bug 60758 – [Qt] SizeHint for QGraphicsWebView is hardcoded

• Status: RESOLVED
• Resolution: INVALID
• Component: Layout and Rendering

[Alberto Mardegan]

Created attachment 93435 [details]
Solution proposed by Palczewski Michał

SizeHint for QGraphicsWebView shouldn't be hardcoded.
Proposed solution in attachments. 

Because of this, the QGraphicsWebView is requesting a smaller size than what really needed, with the result that it breaks the resizeToContents functionality.

[Benjamin Poulain]

On PMO, I suggested to close this as invalid with the following example:

"Let's say I start from a width of 800 pixels. I go on a page that cannot be
layouted with less than 10000 pixels. The content size it adjusted to 10000
pixels width, the layout takes that into account and create a huge view.
Next, I go on amazon.com. Amazon has a flex layout. It adjusts itself to the
current viewport size. Since the width is 10000, the content size will stay
10000 pixel wide for amazon and the layout will look really bad.

Similar case can happen with different pages in the same site, you would see
the view resize to whatever constraint is put by the page layout."

Alberto wants to have the opinion of the team so here we are. What do you think guys?

[Alberto Mardegan]

(Copying my reply from PMO too)

(In reply to comment #1)
> On PMO, I suggested to close this as invalid with the following example:
> 
> "Let's say I start from a width of 800 pixels. I go on a page that cannot be
> layouted with less than 10000 pixels. The content size it adjusted to 10000
> pixels width, the layout takes that into account and create a huge view.
> Next, I go on amazon.com. Amazon has a flex layout. It adjusts itself to the
> current viewport size. Since the width is 10000, the content size will stay
> 10000 pixel wide for amazon and the layout will look really bad.

This is a personal taste :-) Indeed I agree with you, but it IMHO it shouldn't
be Qt's task to decide what looks good and what doesn't.

If the application developer believes that this doesn't looks good, he should
use an appropriate QSizePolicy on the layout containing the view. That's what
QSizePolicy is for.

If the rendered web content is 10000 pixels wide, I wouldn't expect sizeHint() to return anything less than that.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.