RESOLVED FIXED 60754
[EFL] Remove EAPI macro from functions definition 
https://bugs.webkit.org/show_bug.cgi?id=60754
Summary [EFL] Remove EAPI macro from functions definition
Grzegorz Czajkowski
Reported 2011-05-13 01:59:25 PDT
Generally the macro is used in header files only. This patch removes it from definitions.
Attachments
patch (5.40 KB, patch)
2011-05-13 02:13 PDT, Grzegorz Czajkowski 		tonikitoo: review+
tonikitoo: commit-queue-
DetailsFormatted DiffDiff
updated changelog (5.51 KB, patch)
2011-05-13 06:49 PDT, Grzegorz Czajkowski 		gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
updated changelog (5.51 KB, patch)
2011-05-15 23:24 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2011-05-13 02:13:44 PDT
Created attachment 93418 [details] patch
Gyuyoung Kim
Comment 2 2011-05-13 02:26:02 PDT
LGTM. Informal r+.
Lucas De Marchi
Comment 3 2011-05-13 05:32:48 PDT
Comment on attachment 93418 [details] patch LGTM too.
Antonio Gomes
Comment 4 2011-05-13 06:30:45 PDT
Comment on attachment 93418 [details] patch You should say WHY you are removing it in the ChangeLog
Grzegorz Czajkowski
Comment 5 2011-05-13 06:49:39 PDT
Created attachment 93444 [details] updated changelog
Gyuyoung Kim
Comment 6 2011-05-13 20:36:08 PDT
Comment on attachment 93444 [details] updated changelog View in context: https://bugs.webkit.org/attachment.cgi?id=93444&action=review > Source/WebKit/efl/ChangeLog:3 > + Please remove blank line. > Source/WebKit/efl/ChangeLog:4 > + Reviewed by Antonio Gomes. Please add blank line to here
Grzegorz Czajkowski
Comment 7 2011-05-15 23:24:47 PDT
Created attachment 93612 [details] updated changelog Fixed Changelog file.
Antonio Gomes
Comment 8 2011-05-16 06:38:12 PDT
Comment on attachment 93612 [details] updated changelog thanks!
WebKit Commit Bot
Comment 9 2011-05-16 09:05:59 PDT
Comment on attachment 93612 [details] updated changelog Clearing flags on attachment: 93612 Committed r86576: <http://trac.webkit.org/changeset/86576>
WebKit Commit Bot
Comment 10 2011-05-16 09:06:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.