Bug 60754 - [EFL] Remove EAPI macro from functions definition
Summary: [EFL] Remove EAPI macro from functions definition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-13 01:59 PDT by Grzegorz Czajkowski
Modified: 2011-05-16 09:06 PDT (History)
6 users (show)

See Also:

Attachments
patch (5.40 KB, patch)
2011-05-13 02:13 PDT, Grzegorz Czajkowski 		tonikitoo: review+
tonikitoo: commit-queue-
Details | Formatted Diff | Diff
updated changelog (5.51 KB, patch)
2011-05-13 06:49 PDT, Grzegorz Czajkowski 		gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
updated changelog (5.51 KB, patch)
2011-05-15 23:24 PDT, Grzegorz Czajkowski 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2011-05-13 01:59:25 PDT 
Generally the macro is used in header files only. This patch removes it from definitions.
Comment 1 Grzegorz Czajkowski 2011-05-13 02:13:44 PDT 
Created attachment 93418 [details]
patch
Comment 2 Gyuyoung Kim 2011-05-13 02:26:02 PDT 
LGTM. Informal r+.
Comment 3 Lucas De Marchi 2011-05-13 05:32:48 PDT 
Comment on attachment 93418 [details]
patch

LGTM too.
Comment 4 Antonio Gomes 2011-05-13 06:30:45 PDT 
Comment on attachment 93418 [details]
patch

You should say WHY you are removing it in the ChangeLog
Comment 5 Grzegorz Czajkowski 2011-05-13 06:49:39 PDT 
Created attachment 93444 [details]
updated changelog
Comment 6 Gyuyoung Kim 2011-05-13 20:36:08 PDT 
Comment on attachment 93444 [details]
updated changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=93444&action=review

> Source/WebKit/efl/ChangeLog:3
> +

Please remove blank line.

> Source/WebKit/efl/ChangeLog:4
> +        Reviewed by Antonio Gomes.

Please add blank line to here
Comment 7 Grzegorz Czajkowski 2011-05-15 23:24:47 PDT 
Created attachment 93612 [details]
updated changelog

Fixed Changelog file.
Comment 8 Antonio Gomes 2011-05-16 06:38:12 PDT 
Comment on attachment 93612 [details]
updated changelog

thanks!
Comment 9 WebKit Commit Bot 2011-05-16 09:05:59 PDT 
Comment on attachment 93612 [details]
updated changelog

Clearing flags on attachment: 93612

Committed r86576: <http://trac.webkit.org/changeset/86576>
Comment 10 WebKit Commit Bot 2011-05-16 09:06:04 PDT 
All reviewed patches have been landed.  Closing bug.