Bug 60748 - Prune #includes from FrameView.h (Part 2)
Summary: Prune #includes from FrameView.h (Part 2)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-12 20:20 PDT by Sam Weinig
Modified: 2011-05-13 12:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (29.69 KB, patch)
2011-05-12 20:24 PDT, Sam Weinig 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (31.16 KB, patch)
2011-05-12 20:52 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (36.62 KB, patch)
2011-05-12 23:58 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (40.17 KB, patch)
2011-05-13 10:01 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (40.65 KB, patch)
2011-05-13 11:00 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (41.29 KB, patch)
2011-05-13 11:44 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-05-12 20:20:36 PDT 
Prune #includes from FrameView.h (Part 2)
Comment 1 Sam Weinig 2011-05-12 20:24:37 PDT 
Created attachment 93395 [details]
Patch
Comment 2 Sam Weinig 2011-05-12 20:25:12 PDT 
Putting up patch to let the bots attack it.
Comment 3 Collabora GTK+ EWS bot 2011-05-12 20:36:38 PDT 
Comment on attachment 93395 [details]
Patch

Attachment 93395 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8691784
Comment 4 Early Warning System Bot 2011-05-12 20:37:00 PDT 
Comment on attachment 93395 [details]
Patch

Attachment 93395 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8686993
Comment 5 WebKit Review Bot 2011-05-12 20:43:34 PDT 
Comment on attachment 93395 [details]
Patch

Attachment 93395 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8688946
Comment 6 Sam Weinig 2011-05-12 20:52:02 PDT 
Created attachment 93396 [details]
Patch
Comment 7 Early Warning System Bot 2011-05-12 21:04:45 PDT 
Comment on attachment 93396 [details]
Patch

Attachment 93396 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8688955
Comment 8 WebKit Review Bot 2011-05-12 21:10:39 PDT 
Comment on attachment 93396 [details]
Patch

Attachment 93396 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8687918
Comment 9 Gustavo Noronha (kov) 2011-05-12 21:17:10 PDT 
Comment on attachment 93396 [details]
Patch

Attachment 93396 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8689933
Comment 10 WebKit Review Bot 2011-05-12 21:28:34 PDT 
Comment on attachment 93395 [details]
Patch

Attachment 93395 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8693046
Comment 11 WebKit Review Bot 2011-05-12 22:23:40 PDT 
Comment on attachment 93396 [details]
Patch

Attachment 93396 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8685999
Comment 12 WebKit Review Bot 2011-05-12 22:58:58 PDT 
Comment on attachment 93396 [details]
Patch

Attachment 93396 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8688994
Comment 13 Gyuyoung Kim 2011-05-12 23:03:34 PDT 
Comment on attachment 93396 [details]
Patch

Attachment 93396 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/8688997
Comment 14 Sam Weinig 2011-05-12 23:58:53 PDT 
Created attachment 93408 [details]
Patch
Comment 15 WebKit Review Bot 2011-05-13 00:01:25 PDT 
Attachment 93408 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/page/win/FrameCGWin.cpp:32:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/page/chromium/FrameChromium.cpp:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 52 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 Gustavo Noronha (kov) 2011-05-13 00:11:30 PDT 
Comment on attachment 93408 [details]
Patch

Attachment 93408 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8658013
Comment 17 Early Warning System Bot 2011-05-13 00:11:36 PDT 
Comment on attachment 93408 [details]
Patch

Attachment 93408 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8680021
Comment 18 Gyuyoung Kim 2011-05-13 00:18:29 PDT 
Comment on attachment 93408 [details]
Patch

Attachment 93408 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/8694054
Comment 19 WebKit Review Bot 2011-05-13 00:20:17 PDT 
Comment on attachment 93408 [details]
Patch

Attachment 93408 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8691826
Comment 20 WebKit Review Bot 2011-05-13 01:01:27 PDT 
Comment on attachment 93408 [details]
Patch

Attachment 93408 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8694070
Comment 21 WebKit Review Bot 2011-05-13 02:05:13 PDT 
Comment on attachment 93408 [details]
Patch

Attachment 93408 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8687972
Comment 22 Sam Weinig 2011-05-13 10:01:58 PDT 
Created attachment 93472 [details]
Patch
Comment 23 WebKit Review Bot 2011-05-13 10:04:41 PDT 
Attachment 93472 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/page/win/FrameCGWin.cpp:32:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 58 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 24 Early Warning System Bot 2011-05-13 10:29:06 PDT 
Comment on attachment 93472 [details]
Patch

Attachment 93472 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8700053
Comment 25 Sam Weinig 2011-05-13 11:00:18 PDT 
Created attachment 93483 [details]
Patch
Comment 26 WebKit Review Bot 2011-05-13 11:02:38 PDT 
Attachment 93483 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/page/win/FrameCGWin.cpp:32:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 59 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 27 Early Warning System Bot 2011-05-13 11:40:06 PDT 
Comment on attachment 93483 [details]
Patch

Attachment 93483 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8695183
Comment 28 Sam Weinig 2011-05-13 11:44:36 PDT 
Created attachment 93486 [details]
Patch
Comment 29 WebKit Review Bot 2011-05-13 11:46:48 PDT 
Attachment 93486 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/page/win/FrameCGWin.cpp:30:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebKit/qt/Api/qgraphicswebview.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/Api/qgraphicswebview.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 60 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 30 Sam Weinig 2011-05-13 12:09:18 PDT 
Committed r86451: <http://trac.webkit.org/changeset/86451>