Bug 60747 - [EFL] Remove unused option of EWeblauncher
Summary: [EFL] Remove unused option of EWeblauncher
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-12 19:59 PDT by Ryuan Choi
Modified: 2011-05-12 21:59 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.24 KB, patch)
2011-05-12 20:03 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2011-05-12 19:59:16 PDT 
IMO, sudo-workaround option is not necessary.

It makes EWeblauncher started when --help.
Comment 1 Ryuan Choi 2011-05-12 20:03:38 PDT 
Created attachment 93393 [details]
Patch
Comment 2 Gyuyoung Kim 2011-05-12 20:20:21 PDT 
LGTM. Lucas, Do you need this option ?
Comment 3 Lucas De Marchi 2011-05-12 21:00:54 PDT 
Comment on attachment 93393 [details]
Patch

Die die die, unused code!

Informal r+ on my side.
Comment 4 WebKit Commit Bot 2011-05-12 21:58:15 PDT 
The commit-queue encountered the following flaky tests while processing attachment 93393 [details]:

inspector/debugger/debugger-scripts.html bug 59921 (authors: pfeldman@chromium.org and podivilov@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2011-05-12 21:59:27 PDT 
Comment on attachment 93393 [details]
Patch

Clearing flags on attachment: 93393

Committed r86412: <http://trac.webkit.org/changeset/86412>
Comment 6 WebKit Commit Bot 2011-05-12 21:59:32 PDT 
All reviewed patches have been landed.  Closing bug.