Crash when a plug-in tries to load a resource from the application cache

[Anders Carlsson]

Crash when a plug-in tries to load a resource from the application cache

[Anders Carlsson]

Created attachment 93364 [details]
Patch

Comment on attachment 93364 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93364&action=review

> Source/WebCore/ChangeLog:11
> +        This lead to the plug-in stream loader canceling the load, something which the application

typo: lead

> Source/WebCore/loader/DocumentLoader.cpp:601
> +
> +            // Calling ResourceLoader::didReceiveResponse can end up cancelling the load,
> +            // so we need to check if the loader has reached its terminal state.
> +            if (loader->reachedTerminalState())
> +                return;
> +
> +            // Calling ResourceLoader::didReceiveData can end up cancelling the load,
> +            // so we need to check if the loader has reached its terminal state.
>              loader->didReceiveData(data->data(), data->size(), data->size(), true);
> +            if (loader->reachedTerminalState())

The inconsistent way you order the comments is weird and inconsistent.

[Anders Carlsson]

Committed r86397: <http://trac.webkit.org/changeset/86397>

[Yong Li]

Can we assume the http status code is always 200 when resource is loaded from app cache? A status code other than 200 may cause unexpected problems