Bug 60733 – Port Mozilla's IndexedDB tests: indexes with keys and key ranges

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mark Pilgrim (Google)]

Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_indexes.html?force=1

This is a port of a test from Mozilla's IndexedDB test suite. It creates an object store with several rows of data, creates indexes on each key, then iterates each index in a variety of ways (keys, key ranges, etc).

Variations that WebKit fails have been split out into separate tests. This is what remains, which WebKit passes.

[Mark Pilgrim (Google)]

Created attachment 93358 [details]
Patch

[Tony Chang]

Comment on attachment 93358 [details]
Patch

I think this is fine, but a couple questions:
- Are the results deterministic?  It looks like multiple database queries get queued up.  Will they always get resolved in the same order?
- How long does this test take to run?

[Mark Pilgrim (Google)]

In my testing the results are deterministic and nowhere near the timeout threshold. Less than one second on my poor old laptop.

[Tony Chang]

Comment on attachment 93358 [details]
Patch

Ok, I suspect this is fine because queries always get answered in the order they come in.  Ideally, tests should be only tens of ms, but under a second isn't terrible.

[WebKit Commit Bot]

Comment on attachment 93358 [details]
Patch

Clearing flags on attachment: 93358

Committed r86457: <http://trac.webkit.org/changeset/86457>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.