Bug 60718 - Switch paintOutline to use IntRect
Summary: Switch paintOutline to use IntRect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2011-05-12 12:31 PDT by Levi Weintraub
Modified: 2011-05-12 17:05 PDT (History)
4 users (show)

See Also:

Attachments
Patch (9.72 KB, patch)
2011-05-12 15:27 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Patch (9.85 KB, patch)
2011-05-12 16:41 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-05-12 12:31:56 PDT 
It currently takes four ints representing a rect.
Comment 1 Levi Weintraub 2011-05-12 15:27:43 PDT 
Created attachment 93356 [details]
Patch
Comment 2 Simon Fraser (smfr) 2011-05-12 15:30:11 PDT 
Comment on attachment 93356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93356&action=review

> Source/WebCore/rendering/RenderObject.h:795
> +    void paintOutline(GraphicsContext*, IntRect);

const IntRect& please.
Comment 3 Levi Weintraub 2011-05-12 16:41:50 PDT 
Created attachment 93366 [details]
Patch
Comment 4 Levi Weintraub 2011-05-12 16:59:57 PDT 
Thanks for the review!
Comment 5 Levi Weintraub 2011-05-12 17:05:16 PDT 
Comment on attachment 93366 [details]
Patch

Clearing flags on attachment: 93366

Committed r86400: <http://trac.webkit.org/changeset/86400>
Comment 6 Levi Weintraub 2011-05-12 17:05:20 PDT 
All reviewed patches have been landed.  Closing bug.