Bug 60715 - [Qt] 4 of the skipped storage layout tests pass on Qt Linux - skip list to be modified
Summary: [Qt] 4 of the skipped storage layout tests pass on Qt Linux - skip list to be...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: EasyFix, LayoutTestFailure, Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-05-12 11:36 PDT by Ramakrishna Sakamuri
Modified: 2011-05-17 10:25 PDT (History)
6 users (show)

See Also:


Attachments
removed the passed test from Qt skipped list (1.24 KB, patch)
2011-05-12 12:06 PDT, Ramakrishna Sakamuri
benjamin: review-
benjamin: commit-queue-
Details | Formatted Diff | Diff
updated patch/changelog submited (1.22 KB, patch)
2011-05-16 11:59 PDT, Ramakrishna Sakamuri
no flags Details | Formatted Diff | Diff
fixed tab issue in previous patch submited (1.24 KB, patch)
2011-05-17 09:53 PDT, Ramakrishna Sakamuri
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ramakrishna Sakamuri 2011-05-12 11:36:27 PDT
These four storage layout tests are currently listed in skipped list for Qt platform but are passing on Qt-Linux.

LayoutTests/storage/database-lock-after-reload.html
LayoutTests/storage/empty-statement.html
LayoutTests/storage/execute-sql-args.html
LayoutTests/storage/hash-change-with-xhr.html

Platform details:
Linux desktop on Ubuntu 10.04
Linux version 2.6.32-31-generic
Qt 4.7.2
WebKit version r86351

I will submit a patch for the updated skip list.
Comment 1 Ramakrishna Sakamuri 2011-05-12 12:06:13 PDT
Created attachment 93322 [details]
removed the passed test from Qt skipped list
Comment 2 Benjamin Poulain 2011-05-13 04:53:17 PDT
Comment on attachment 93322 [details]
removed the passed test from Qt skipped list

View in context: https://bugs.webkit.org/attachment.cgi?id=93322&action=review

There is something very weird with your patch. The diff does not make much sense.

> LayoutTests/ChangeLog:5
> +   [Qt] [Qt] 4 of the skipped storage layout tests pass on Qt Linux - skip list to be modified

[Qt] [Qt] ?
Comment 3 Ramakrishna Sakamuri 2011-05-16 11:59:47 PDT
Created attachment 93681 [details]
updated patch/changelog submited
Comment 4 WebKit Review Bot 2011-05-16 13:08:18 PDT
Attachment 93681 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

LayoutTests/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Chang Shu 2011-05-17 08:12:36 PDT
Comment on attachment 93681 [details]
updated patch/changelog submited

View in context: https://bugs.webkit.org/attachment.cgi?id=93681&action=review

>> LayoutTests/ChangeLog:6
>> +	https://bugs.webkit.org/show_bug.cgi?id=60715
> 
> Line contains tab character.  [whitespace/tab] [5]

Please fix the tab issue.
Comment 6 Ramakrishna Sakamuri 2011-05-17 09:53:27 PDT
Created attachment 93782 [details]
fixed tab issue in previous patch submited
Comment 7 WebKit Commit Bot 2011-05-17 10:25:26 PDT
Comment on attachment 93782 [details]
fixed tab issue in previous patch submited

Clearing flags on attachment: 93782

Committed r86682: <http://trac.webkit.org/changeset/86682>
Comment 8 WebKit Commit Bot 2011-05-17 10:25:31 PDT
All reviewed patches have been landed.  Closing bug.