Bug 60709 - Assertion failure when requesting that storage be deleted for an origin without storage
Summary: Assertion failure when requesting that storage be deleted for an origin witho...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jessie Berlin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-12 10:52 PDT by Jessie Berlin
Modified: 2011-05-12 14:31 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2011-05-12 11:07 PDT, Jessie Berlin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2011-05-12 10:52:00 PDT
ASSERTION FAILED: !path.isEmpty()
/Volumes/Data/jessieberlin/src/Safari/OpenSource/Source/WebCore/storage/StorageTracker.cpp(458) : void WebCore::StorageTracker::syncDeleteOrigin(const WTF::String&)
1   WebCore::StorageTracker::syncDeleteOrigin(WTF::String const&)
2   WebCore::LocalStorageTask::performTask()
3   WebCore::LocalStorageThread::threadEntryPoint()
4   WebCore::LocalStorageThread::threadEntryPointCallback(void*)
5   WTF::threadEntryPoint(void*)
6   _pthread_start
7   thread_start
Comment 1 Anton D'Auria 2011-05-12 10:56:23 PDT
This assertion is too strict. Requesting StorageTracker to delete local storage for an origin that has no local storage is not a misuse of the API.
Comment 2 Jessie Berlin 2011-05-12 11:07:06 PDT
Created attachment 93308 [details]
Patch
Comment 3 Jessie Berlin 2011-05-12 12:41:53 PDT
Comment on attachment 93308 [details]
Patch

Thanks for the review, Darin! Commited in http://trac.webkit.org/changeset/86371
Comment 4 WebKit Review Bot 2011-05-12 14:31:28 PDT
http://trac.webkit.org/changeset/86371 might have broken Leopard Intel Debug (Tests)
The following tests are not passing:
fast/lists/003-vertical.html
fonts/cursive.html