RESOLVED FIXED 60688
[Qt] Arm debug build failing on ARMAssembler::debugOffset() 
https://bugs.webkit.org/show_bug.cgi?id=60688
Summary [Qt] Arm debug build failing on ARMAssembler::debugOffset()
Keith Kyzivat
Reported 2011-05-11 21:39:50 PDT
ARM debug builds that include ARMAssembler.h fail to find symbol m_formatter: ../../../webkit/Source/JavaScriptCore/assembler/ARMAssembler.h:686:41: error: 'm_formatter' was not declared in this scope m_formatter isn't declared anywhere visible to ARMAssembler.h I do see that this was originally declared in ARMv7Assembler.h, with a similar debugOffset() method using it.. This has been since replaced with a call to m_buffer.debugOffset(). I'm not too familiar with this code, so I'm not sure what exactly the right thing to do is.
Attachments
Patch (1.28 KB, patch)
2011-05-11 22:00 PDT, Keith Kyzivat 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Kyzivat
Comment 1 2011-05-11 22:00:38 PDT
Created attachment 93243 [details] Patch
Keith Kyzivat
Comment 2 2011-05-11 22:02:16 PDT
Patch builds without error -- and looks like the right thing to do when comparing to what ARMv7Assembler.h.
Csaba Osztrogonác
Comment 3 2011-05-11 23:32:18 PDT
Comment on attachment 93243 [details] Patch LGTM, r=me
WebKit Commit Bot
Comment 4 2011-05-12 00:31:55 PDT
Comment on attachment 93243 [details] Patch Clearing flags on attachment: 93243 Committed r86316: <http://trac.webkit.org/changeset/86316>
WebKit Commit Bot
Comment 5 2011-05-12 00:32:00 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2011-05-12 01:27:58 PDT
http://trac.webkit.org/changeset/86316 might have broken Leopard Intel Debug (Tests) The following tests are not passing: editing/deleting/delete-ligature-001.html editing/deleting/delete-ligature-002.html editing/deleting/delete-ligature-003.html platform/mac/editing/input/devanagari-ligature.html
Ademar Reis
Comment 7 2011-05-13 11:58:03 PDT
Revision r86316 cherry-picked into qtwebkit-2.2 with commit b718e0e <http://gitorious.org/webkit/qtwebkit/commit/b718e0e>
Note You need to log in before you can comment on or make changes to this bug.