Bug 60680 - Disable gc validation in release builds
Summary: Disable gc validation in release builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-11 17:47 PDT by Oliver Hunt
Modified: 2011-05-18 11:28 PDT (History)
0 users

See Also:


Attachments
Patch (1.21 KB, patch)
2011-05-18 11:19 PDT, Oliver Hunt
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-05-11 17:47:36 PDT
task
Comment 1 Oliver Hunt 2011-05-11 17:59:00 PDT
We're just leaving this in the build for a few days to help diagnose some crashers.
Comment 2 Oliver Hunt 2011-05-18 11:19:28 PDT
Created attachment 93944 [details]
Patch
Comment 3 Adam Roben (:aroben) 2011-05-18 11:27:37 PDT
Comment on attachment 93944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93944&action=review

> Source/JavaScriptCore/wtf/Platform.h:1218
> +#ifndef NDEBUG
> +#if !defined(ENABLE_GC_VALIDATION)

Could use && instead of two #ifs. Or if you are going to use two #ifs you could make them both #ifndef.
Comment 4 Oliver Hunt 2011-05-18 11:28:57 PDT
Committed r86779: <http://trac.webkit.org/changeset/86779>