Enable OwnPtr strict mode in libxml2 XMLDocumentParser
Created attachment 93217 [details] Patch
Comment on attachment 93217 [details] Patch Attachment 93217 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8691388
Created attachment 93222 [details] Patch
Comment on attachment 93222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93222&action=review > Source/WebCore/dom/XMLDocumentParserLibxml2.cpp:191 > - OwnPtr<PendingCallback> callback(m_callbacks.takeFirst()); > + OwnPtr<PendingCallback> callback = adoptPtr(m_callbacks.takeFirst()); This change is not correct. m_callbacks should old OwnPtrs and takeFirst should return a PassOwnPtr. I thought Maceij wrote a patch that did that? Maybe he added the ability to Deque but didn't change the type in this file?
s/old/hold/
(In reply to comment #4) > This change is not correct. m_callbacks should old OwnPtrs and takeFirst should return a PassOwnPtr. I thought Maceij wrote a patch that did that? Maybe he added the ability to Deque but didn't change the type in this file? I don't see such code in Dequeue. Do you have an idea when he made this change?
Maybe he never landed it? We should ask him on irc.
*** This bug has been marked as a duplicate of bug 59394 ***