RESOLVED DUPLICATE of bug 5939460676
Enable OwnPtr strict mode in libxml2 XMLDocumentParser 
https://bugs.webkit.org/show_bug.cgi?id=60676
Summary Enable OwnPtr strict mode in libxml2 XMLDocumentParser
Patrick R. Gansterer
Reported 2011-05-11 17:15:01 PDT
Enable OwnPtr strict mode in libxml2 XMLDocumentParser
Attachments
Patch (6.97 KB, patch)
2011-05-11 17:16 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (2.22 KB, patch)
2011-05-11 17:35 PDT, Patrick R. Gansterer 		abarth: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-05-11 17:16:19 PDT
Created attachment 93217 [details] Patch
WebKit Review Bot
Comment 2 2011-05-11 17:22:29 PDT
Comment on attachment 93217 [details] Patch Attachment 93217 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8691388
Patrick R. Gansterer
Comment 3 2011-05-11 17:35:11 PDT
Created attachment 93222 [details] Patch
Adam Barth
Comment 4 2011-05-11 17:39:02 PDT
Comment on attachment 93222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93222&action=review > Source/WebCore/dom/XMLDocumentParserLibxml2.cpp:191 > - OwnPtr<PendingCallback> callback(m_callbacks.takeFirst()); > + OwnPtr<PendingCallback> callback = adoptPtr(m_callbacks.takeFirst()); This change is not correct. m_callbacks should old OwnPtrs and takeFirst should return a PassOwnPtr. I thought Maceij wrote a patch that did that? Maybe he added the ability to Deque but didn't change the type in this file?
Adam Barth
Comment 5 2011-05-11 17:39:21 PDT
s/old/hold/
Patrick R. Gansterer
Comment 6 2011-05-11 18:35:12 PDT
(In reply to comment #4) > This change is not correct. m_callbacks should old OwnPtrs and takeFirst should return a PassOwnPtr. I thought Maceij wrote a patch that did that? Maybe he added the ability to Deque but didn't change the type in this file? I don't see such code in Dequeue. Do you have an idea when he made this change?
Adam Barth
Comment 7 2011-05-11 18:50:48 PDT
Maybe he never landed it? We should ask him on irc.
Patrick R. Gansterer
Comment 8 2011-05-12 14:40:13 PDT
*** This bug has been marked as a duplicate of bug 59394 ***
Note You need to log in before you can comment on or make changes to this bug.