Bug 60666 – [Chromium] Add hook to create arbitrary Storage objects

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Platform

[Ben Olmstead]

Created attachment 93189 [details]
add getStorageForOrigin() to Chromium WebFrame

We want to expose a Chromium extension's localStorage to its own content scripts; for that we need a way to get Storage objects for (somewhat) arbitrary security origins.

Chromium side of this change: http://codereview.chromium.org/7007001/ (for http://code.google.com/p/chromium/issues/detail?id=30224 ).

[WebKit Review Bot]

Attachment 93189 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1

Source/WebKit/chromium/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Barth]

Comment on attachment 93189 [details]
add getStorageForOrigin() to Chromium WebFrame

View in context: https://bugs.webkit.org/attachment.cgi?id=93189&action=review

> Source/WebKit/chromium/public/WebFrame.h:2
> - * Copyright (C) 2009 Google Inc. All rights reserved.
> + * Copyright (C) 2011 Google Inc. All rights reserved.

WebKit style is to append years to the copyright lines (or just leave them along).

> Source/WebKit/chromium/public/WebFrame.h:280
> +    // Creates a Storage object for the given origin, which need not match the
> +    // current page's origin.
> +    virtual v8::Handle<v8::Value> getStorageForOrigin(const WebSecurityOrigin&) = 0;

This just seems like piling junk onto WebFrame.

> Source/WebKit/chromium/public/WebSecurityOrigin.h:62
> +    WEBKIT_API static WebSecurityOrigin create(const WebString& protocol, const WebString& host, int port);

This API shouldn't exist.  You should just use a URL.

[Eric Seidel (no email)]

Comment on attachment 93189 [details]
add getStorageForOrigin() to Chromium WebFrame

Adam's review sounds like an r- more than just a cq-.

[Stephen Chenney]

https://code.google.com/p/chromium/issues/detail?id=230563