Bug 60663 – Change nodeAtPoint to take IntPoint instead of int x, int y

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

Change nodeAtPoint hit testing code to take an IntPoint argument instead of a pair of ints for x, y.

[Levi Weintraub]

Woo!

[Emil A Eklund]

Created attachment 93710 [details]
Patch

[Emil A Eklund]

I tried to keep this as small as I could, more clean up and changing functions called by nodeAtPoint will follow in separate patches.

I realize that the name pointInContainer might not be entirely correct but it was the best I could come up with. If you can think of a better name please do tell.

[Simon Fraser (smfr)]

Comment on attachment 93710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93710&action=review

> Source/WebCore/rendering/RenderBlock.cpp:3902
> +    tx += x();
> +    ty += y();

I don't like it when methods change parameter values. Maybe a local IntSize localOffset(tx + x(), ty + y())?

[Eric Seidel (no email)]

Comment on attachment 93710 [details]
Patch

LGTM.  Please respond to smfr before landing of course.

[Emil A Eklund]

Created attachment 93715 [details]
Patch

[Emil A Eklund]

> I don't like it when methods change parameter values. Maybe a local IntSize localOffset(tx + x(), ty + y())?

That's a good idea. Made the change you suggested.

Please take another look.

[Eric Seidel (no email)]

Comment on attachment 93715 [details]
Patch

still LGTM.

[Emil A Eklund]

Created attachment 93788 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 93788 [details]
Patch for landing

Rejecting attachment 93788 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 1

Last 500 characters of output:
autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://queues.webkit.org/results/8709232

[WebKit Commit Bot]

Comment on attachment 93788 [details]
Patch for landing

Clearing flags on attachment: 93788

Committed r86705: <http://trac.webkit.org/changeset/86705>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 93788 [details]:

http/tests/websocket/tests/multiple-connections.html bug 53825 (author: [e-mail])
The commit-queue is continuing to process your patch.