Bug 60651 - Teach validate-committer-lists how to validate committers bugzilla_email()
Summary: Teach validate-committer-lists how to validate committers bugzilla_email()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-11 13:26 PDT by Eric Seidel (no email)
Modified: 2011-05-11 17:05 PDT (History)
3 users (show)

See Also:


Attachments
Patch (10.09 KB, patch)
2011-05-11 13:27 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (10.61 KB, patch)
2011-05-11 13:42 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch for landing (11.03 KB, patch)
2011-05-11 13:57 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-05-11 13:26:34 PDT
Teach validate-committer-lists how to validate committers bugzilla_email()
Comment 1 Eric Seidel (no email) 2011-05-11 13:27:24 PDT
Created attachment 93165 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-11 13:32:48 PDT
Comment on attachment 93165 [details]
Patch

Found a bug, new patch coming.
Comment 3 Eric Seidel (no email) 2011-05-11 13:42:50 PDT
Created attachment 93174 [details]
Patch
Comment 4 David Levin 2011-05-11 13:52:12 PDT
Comment on attachment 93174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93174&action=review

You could cq+ it. Depends on how you feel about the typo.

> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:195
> +    # This only works if your account has edituser privilages.

typo: privileges
Comment 5 Eric Seidel (no email) 2011-05-11 13:56:43 PDT
(In reply to comment #4)
> (From update of attachment 93174 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=93174&action=review
> 
> You could cq+ it. Depends on how you feel about the typo.
> 
> > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:195
> > +    # This only works if your account has edituser privilages.
> 
> typo: privileges

Turns out it was spelled wrong in a second place!  The message that the commit-queue spams to bugs when users don't have cq privileges.  I guess I never knew how to spell the word. :(
Comment 6 Eric Seidel (no email) 2011-05-11 13:57:22 PDT
Created attachment 93179 [details]
Patch for landing
Comment 7 Eric Seidel (no email) 2011-05-11 13:57:39 PDT
Thankfully we have apply-from-bug and land-safely, so fixing typos is easy. :)
Comment 8 WebKit Commit Bot 2011-05-11 17:05:00 PDT
Comment on attachment 93179 [details]
Patch for landing

Clearing flags on attachment: 93179

Committed r86288: <http://trac.webkit.org/changeset/86288>
Comment 9 WebKit Commit Bot 2011-05-11 17:05:06 PDT
All reviewed patches have been landed.  Closing bug.