Bug 60649 - [Qt] Extract code to set mouse event modifiers into common function
Summary: [Qt] Extract code to set mouse event modifiers into common function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-05-11 13:00 PDT by Daniel Bates
Modified: 2011-05-11 14:36 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2011-05-11 13:11 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2011-05-11 13:00:28 PDT 
Both PlatformMouseEvent(QInputEvent*, int clickCount) and PlatformMouseEvent(QGraphicsSceneMouseEvent*, int clickCount) contain identical code to set the state of the keyboard modifiers for a mouse event. Instead, we should extract this code into a common function, say mouseEventModifiersFromQtKeyboardModifiers() so as to remove duplicate code.
Comment 1 Daniel Bates 2011-05-11 13:11:07 PDT 
Created attachment 93163 [details]
Patch
Comment 2 Daniel Bates 2011-05-11 14:35:54 PDT 
Comment on attachment 93163 [details]
Patch

Clearing flags on attachment: 93163

Committed r86273: <http://trac.webkit.org/changeset/86273>
Comment 3 Daniel Bates 2011-05-11 14:36:00 PDT 
All reviewed patches have been landed.  Closing bug.