Bug 60642 - [CMAKE] Move EFL-specific file to CMakeListsEfl.txt
Summary: [CMAKE] Move EFL-specific file to CMakeListsEfl.txt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas De Marchi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-11 11:20 PDT by Lucas De Marchi
Modified: 2011-05-12 18:07 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.23 KB, patch)
2011-05-11 11:27 PDT, Lucas De Marchi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas De Marchi 2011-05-11 11:20:57 PDT 
[CMAKE] Move EFL-specific file to CMakeListsEfl.txt
Comment 1 Lucas De Marchi 2011-05-11 11:27:26 PDT 
Created attachment 93150 [details]
Patch
Comment 2 Antonio Gomes 2011-05-11 12:15:18 PDT 
Comment on attachment 93150 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93150&action=review

> Source/WebCore/CMakeLists.txt:1958
> +SET(WebCore_LIBRARIES ${JavaScriptCore_LIBRARY_NAME})
> +SET(WebCore_LINK_FLAGS "")
> +INCLUDE_IF_EXISTS(${WEBCORE_DIR}/CMakeLists${PORT}.txt)

looks unrelated, but OK :)
Comment 3 Lucas De Marchi 2011-05-11 12:23:14 PDT 
Comment on attachment 93150 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93150&action=review

Thanks.

>> Source/WebCore/CMakeLists.txt:1958
>> +INCLUDE_IF_EXISTS(${WEBCORE_DIR}/CMakeLists${PORT}.txt)
> 
> looks unrelated, but OK :)

It's related... it's the same code as below, but moved to this place as I said in the changelog.
Comment 4 WebKit Commit Bot 2011-05-11 16:27:04 PDT 
The commit-queue encountered the following flaky tests while processing attachment 93150 [details]:

inspector/debugger/debugger-scripts.html bug 59921 (authors: pfeldman@chromium.org and podivilov@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2011-05-11 16:28:18 PDT 
Comment on attachment 93150 [details]
Patch

Clearing flags on attachment: 93150

Committed r86283: <http://trac.webkit.org/changeset/86283>
Comment 6 WebKit Commit Bot 2011-05-11 16:28:23 PDT 
All reviewed patches have been landed.  Closing bug.