Bug 60641 - [WK2] Skip fast/events/tabindex-focus-blur-all.html for WebKit2
Summary: [WK2] Skip fast/events/tabindex-focus-blur-all.html for WebKit2
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on:
Blocks: 58327
  Show dependency treegraph
 
Reported: 2011-05-11 11:14 PDT by Chang Shu
Modified: 2011-08-16 13:44 PDT (History)
4 users (show)

See Also:


Attachments
fix patch (1.30 KB, patch)
2011-05-11 11:17 PDT, Chang Shu
no flags Details | Formatted Diff | Diff
fix patch 2: follow review (1.27 KB, patch)
2011-05-12 06:20 PDT, Chang Shu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2011-05-11 11:14:36 PDT
This test appears to pass but it actually crashes internally and takes 20s to finish. The crash is logged in 58327.
We should skip this test.
Comment 1 Chang Shu 2011-05-11 11:17:53 PDT
Created attachment 93148 [details]
fix patch
Comment 2 WebKit Review Bot 2011-05-11 11:18:28 PDT
Comment on attachment 93148 [details]
fix patch

Rejecting attachment 93148 [details] from review queue.

cshu@webkit.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 3 Chang Shu 2011-05-11 11:20:11 PDT
Comment on attachment 93148 [details]
fix patch

I accidentally put '+' for '?'s. :)
Comment 4 Darin Adler 2011-05-11 15:01:58 PDT
Comment on attachment 93148 [details]
fix patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93148&action=review

[Leopard Intel Debug Tests]?

> LayoutTests/platform/mac-wk2/Skipped:1534
> +# [Leopard Intel Debug Tests] fast/events/tabindex-focus-blur-all.html crashing since (83513, 83521]

[Leopard Intel Debug Tests]?
Comment 5 Chang Shu 2011-05-11 16:22:33 PDT
I also observed a crash for wk2 release build and commented on this existing one. Probably I should open a new bug.
> > LayoutTests/platform/mac-wk2/Skipped:1534
> > +# [Leopard Intel Debug Tests] fast/events/tabindex-focus-blur-all.html crashing since (83513, 83521]
> 
> [Leopard Intel Debug Tests]?
Comment 6 Chang Shu 2011-05-12 06:20:47 PDT
Created attachment 93278 [details]
fix patch 2: follow review
Comment 7 Ryosuke Niwa 2011-05-16 12:56:48 PDT
Comment on attachment 93278 [details]
fix patch 2: follow review

View in context: https://bugs.webkit.org/attachment.cgi?id=93278&action=review

> LayoutTests/ChangeLog:9
> +        This test appears to pass but it actually crashes internally and takes 20s to finish.
> +        The crash is logged in bug 60696.

Where is this test crashing?  I don't see it crashing on waterfall.
Comment 8 Chang Shu 2011-05-17 08:06:28 PDT
> > +        This test appears to pass but it actually crashes internally and takes 20s to finish.
> > +        The crash is logged in bug 60696.
> 
> Where is this test crashing?  I don't see it crashing on waterfall.

I found the problem is shown in the latest results:
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r86671%20%2811729%29/fast/events/tabindex-focus-blur-all-stderr.txt
Comment 9 Eric Seidel (no email) 2011-07-05 20:40:22 PDT
This patch is ancient.
Comment 10 Chang Shu 2011-08-16 13:44:20 PDT
Comment on attachment 93278 [details]
fix patch 2: follow review

clear flags. the status was set to wont fix already.