Bug 60635 - Video track sometimes fails to draw
Summary: Video track sometimes fails to draw
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media Elements (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-05-11 09:42 PDT by Eric Carlson
Modified: 2011-06-03 14:10 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch. (1.47 KB, patch)
2011-05-11 10:07 PDT, Eric Carlson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2011-05-11 09:42:11 PDT
If HTMLMediaElement replaces the MediaPlayer after its display state has been set to "video", the new media engine has no way to know that it is allowed to display video.

If the display state is reset whenever MediaPlayer is replaced,  the media engine will get the correct state when it is recalculated.

<rdar://problem/9281951>
Comment 1 Eric Carlson 2011-05-11 10:07:42 PDT
Created attachment 93140 [details]
Proposed patch.
Comment 2 Darin Adler 2011-05-11 10:33:19 PDT
Comment on attachment 93140 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=93140&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:713
> +    // Reset display mode to force a recalculation of what to show becuase we are resetting the player.

This misspells because.
Comment 3 Eric Carlson 2011-05-11 10:43:13 PDT
http://trac.webkit.org/changeset/86245
Comment 4 Ademar Reis 2011-06-03 14:10:26 PDT
Revision r86245 cherry-picked into qtwebkit-2.2 with commit 3f5fab4 <http://gitorious.org/webkit/qtwebkit/commit/3f5fab4>