Bug 60631 - WebKit2 doesn't clear the pendingAPIRequestURL on in-page anchor navigation
: WebKit2 doesn't clear the pendingAPIRequestURL on in-page anchor navigation
Status: RESOLVED FIXED
: WebKit
WebKit2
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
: InRadar
:
:
  Show dependency treegraph
 
Reported: 2011-05-11 08:59 PST by
Modified: 2011-05-11 09:46 PST (History)


Attachments
Patch to add a call to clearPendingAPIRequestURL for in-page anchor navigations (1.25 KB, patch)
2011-05-11 09:25 PST, John Sullivan
darin: review+
Review Patch | Details | Formatted Diff | Diff
Added bugzilla bug number to ChangeLog (1.33 KB, patch)
2011-05-11 09:31 PST, John Sullivan
darin: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-05-11 08:59:26 PST
WebKit2 clears the WebPageProxy's pendingAPIRequestURL when a provisional load starts, but does not clear it on an in-page anchor navigation. In-page anchor navigations never cause a provisional load to start, so the pendingAPIRequestURL is never cleared. This causes trouble for clients that test for a pendingAPIRequestURL later.

In Radar as <rdar://problem/9420520>.
------- Comment #1 From 2011-05-11 09:25:18 PST -------
Created an attachment (id=93130) [details]
Patch to add a call to clearPendingAPIRequestURL for in-page anchor navigations
------- Comment #2 From 2011-05-11 09:27:28 PST -------
Attachment 93130 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #3 From 2011-05-11 09:30:09 PST -------
(From update of attachment 93130 [details])
Need to include the bugs.webkit.org bug number too.
------- Comment #4 From 2011-05-11 09:30:21 PST -------
(From update of attachment 93130 [details])
Bug URL, I mean.
------- Comment #5 From 2011-05-11 09:31:43 PST -------
Created an attachment (id=93133) [details]
Added bugzilla bug number to ChangeLog
------- Comment #6 From 2011-05-11 09:46:12 PST -------
Fixed in r86240.