Bug 60607 - Stop including Console.h just to get Console enum types
Summary: Stop including Console.h just to get Console enum types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-10 21:19 PDT by Sam Weinig
Modified: 2011-05-11 12:03 PDT (History)
2 users (show)

See Also:


Attachments
Patch (22.42 KB, patch)
2011-05-10 21:22 PDT, Sam Weinig
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (23.23 KB, patch)
2011-05-10 21:51 PDT, Sam Weinig
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-05-10 21:19:05 PDT
Stop including Console.h just to get Console enum types
Comment 1 Sam Weinig 2011-05-10 21:22:58 PDT
Created attachment 93069 [details]
Patch
Comment 2 Early Warning System Bot 2011-05-10 21:40:46 PDT
Comment on attachment 93069 [details]
Patch

Attachment 93069 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8690129
Comment 3 Sam Weinig 2011-05-10 21:51:27 PDT
Created attachment 93070 [details]
Patch
Comment 4 Sam Weinig 2011-05-10 21:56:25 PDT
Letting the bots run on this.
Comment 5 Eric Seidel (no email) 2011-05-10 22:15:26 PDT
Comment on attachment 93070 [details]
Patch

Is this to improve build times?  LGTM.
Comment 6 WebKit Review Bot 2011-05-10 23:16:23 PDT
Comment on attachment 93069 [details]
Patch

Attachment 93069 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8689184
Comment 7 Sam Weinig 2011-05-11 12:03:25 PDT
Committed r86251: <http://trac.webkit.org/changeset/86251>