RESOLVED FIXED 60603
Implement various CSS font properties in CSSStyleApplyProperty. 
https://bugs.webkit.org/show_bug.cgi?id=60603
Summary Implement various CSS font properties in CSSStyleApplyProperty.
Luke Macpherson
Reported 2011-05-10 20:08:09 PDT
Implement various CSS font properties in CSSStyleApplyProperty.
Attachments
Patch (13.10 KB, patch)
2011-05-10 20:19 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2011-05-10 20:19:45 PDT
Created attachment 93067 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-10 22:13:40 PDT
Comment on attachment 93067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93067&action=review > Source/WebCore/css/CSSStyleApplyProperty.cpp:412 > + (fontDescription.*m_setter)(*primitiveValue); FontDescription has an m_setter?
Luke Macpherson
Comment 3 2011-05-11 16:41:52 PDT
Comment on attachment 93067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93067&action=review >> Source/WebCore/css/CSSStyleApplyProperty.cpp:412 >> + (fontDescription.*m_setter)(*primitiveValue); > > FontDescription has an m_setter? m_setter is the function pointer defined on line 417 of this patch.
Luke Macpherson
Comment 4 2011-05-24 17:39:48 PDT
Patch still applies cleanly, builds, passes tests. ;)
WebKit Commit Bot
Comment 5 2011-05-25 23:46:32 PDT
Comment on attachment 93067 [details] Patch Clearing flags on attachment: 93067 Committed r87362: <http://trac.webkit.org/changeset/87362>
WebKit Commit Bot
Comment 6 2011-05-25 23:46:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.