Bug 60593 - Flesh out RenderLayer's ScrollableArea implementation a little more
Summary: Flesh out RenderLayer's ScrollableArea implementation a little more
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-10 15:42 PDT by Simon Fraser (smfr)
Modified: 2011-05-11 13:55 PDT (History)
9 users (show)

See Also:


Attachments
Patch (5.93 KB, patch)
2011-05-10 16:05 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (5.81 KB, patch)
2011-05-10 16:24 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (5.82 KB, patch)
2011-05-11 10:00 PDT, Simon Fraser (smfr)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-05-10 15:42:41 PDT
RenderLayer needs to override a few more ScrollableArea methods.
Comment 1 Simon Fraser (smfr) 2011-05-10 16:05:23 PDT
Created attachment 93033 [details]
Patch
Comment 2 Early Warning System Bot 2011-05-10 16:19:28 PDT
Comment on attachment 93033 [details]
Patch

Attachment 93033 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8687102
Comment 3 Simon Fraser (smfr) 2011-05-10 16:24:32 PDT
Created attachment 93040 [details]
Patch
Comment 4 WebKit Review Bot 2011-05-10 17:33:55 PDT
Comment on attachment 93040 [details]
Patch

Attachment 93040 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8684186
Comment 5 WebKit Review Bot 2011-05-10 18:56:49 PDT
Comment on attachment 93040 [details]
Patch

Attachment 93040 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8685193
Comment 6 WebKit Review Bot 2011-05-10 18:59:57 PDT
Comment on attachment 93040 [details]
Patch

Attachment 93040 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8684225
Comment 7 WebKit Review Bot 2011-05-10 19:27:36 PDT
Comment on attachment 93040 [details]
Patch

Attachment 93040 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8688148
Comment 8 Simon Fraser (smfr) 2011-05-10 20:57:48 PDT
Another commit landed under this last patch, breaking it.
Comment 9 Gyuyoung Kim 2011-05-10 21:21:48 PDT
Comment on attachment 93040 [details]
Patch

Attachment 93040 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/8691102
Comment 10 Eric Seidel (no email) 2011-05-10 22:25:41 PDT
Comment on attachment 93040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93040&action=review

> Source/WebCore/platform/ScrollableArea.h:124
> +    virtual IntRect visibleContentRect(bool /*includeScrollbars*/ = false) const { ASSERT_NOT_REACHED(); return IntRect(); }

We generally prefer enums over bools (I know this isn't your code, but eventually we should fix it.)
Comment 11 Eric Seidel (no email) 2011-05-10 22:26:28 PDT
We should teach the cr-linux-ews not to cq- a patch when it can't be applied.
Comment 12 Collabora GTK+ EWS bot 2011-05-11 02:17:22 PDT
Comment on attachment 93040 [details]
Patch

Attachment 93040 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8691173
Comment 13 Simon Fraser (smfr) 2011-05-11 10:00:17 PDT
Created attachment 93138 [details]
Patch
Comment 14 Simon Fraser (smfr) 2011-05-11 13:55:42 PDT
http://trac.webkit.org/changeset/86262