WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
60582
Crash switching overlay/non-overlay scrollbar preference still possible
https://bugs.webkit.org/show_bug.cgi?id=60582
Summary
Crash switching overlay/non-overlay scrollbar preference still possible
Beth Dakin
Reported
2011-05-10 14:28:38 PDT
There are still some reports of crashing when switching the overlay/non-overlay scrollbar preference. We have not found a way to reproduce any of these crashes. I have a fix that prevents any work from being done on pages that are in the page cache when the preference is switched. <
rdar://problem/9323983
>
Attachments
Patch
(20.75 KB, patch)
2011-05-10 15:13 PDT
,
Beth Dakin
no flags
Details
Formatted Diff
Diff
Patch
(20.75 KB, patch)
2011-05-10 15:18 PDT
,
Beth Dakin
no flags
Details
Formatted Diff
Diff
Patch
(20.74 KB, patch)
2011-05-10 15:28 PDT
,
Beth Dakin
darin
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Beth Dakin
Comment 1
2011-05-10 15:13:06 PDT
Created
attachment 93023
[details]
Patch
WebKit Review Bot
Comment 2
2011-05-10 15:15:28 PDT
Attachment 93023
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/page/FrameView.h:270: The parameter name "active" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/mac/ScrollAnimatorMac.h:84: The parameter name "active" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 3
2011-05-10 15:18:01 PDT
Created
attachment 93025
[details]
Patch
WebKit Review Bot
Comment 4
2011-05-10 15:20:09 PDT
Attachment 93025
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/mac/ScrollAnimatorMac.h:84: The parameter name "active" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 5
2011-05-10 15:28:39 PDT
Created
attachment 93027
[details]
Patch
Beth Dakin
Comment 6
2011-05-10 15:38:14 PDT
Thanks Darin! Committed change with revision 86184.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug