RESOLVED FIXED 60579
EWS bots should be robust against test-webkitpy hangs
https://bugs.webkit.org/show_bug.cgi?id=60579
Summary EWS bots should be robust against test-webkitpy hangs
Eric Seidel (no email)
Reported 2011-05-10 14:03:59 PDT
EWS bots should be robust against test-webkitpy hangs
Attachments
Patch (3.15 KB, patch)
2011-05-10 14:04 PDT, Eric Seidel (no email)
no flags
updated changelog (3.83 KB, patch)
2011-05-10 14:09 PDT, Eric Seidel (no email)
no flags
now ignoring chromium gclient content too (3.99 KB, patch)
2011-05-10 14:18 PDT, Eric Seidel (no email)
no flags
Patch (3.83 KB, patch)
2011-05-10 17:16 PDT, Eric Seidel (no email)
abarth: review+
abarth: commit-queue-
Eric Seidel (no email)
Comment 1 2011-05-10 14:04:35 PDT
Eric Seidel (no email)
Comment 2 2011-05-10 14:09:44 PDT
Created attachment 93005 [details] updated changelog
Eric Seidel (no email)
Comment 3 2011-05-10 14:13:28 PDT
The only problem with this patch as written is that it will remove all the gclient directories for Chromium. I'm not sure if that matters or not. It might slow down the chromium EWSes more than we want. I could add another --exclude line which ignores Source/WebKit/chromium
Adam Barth
Comment 4 2011-05-10 14:15:06 PDT
Comment on attachment 93005 [details] updated changelog View in context: https://bugs.webkit.org/attachment.cgi?id=93005&action=review > Tools/EWSTools/start-queue.sh:61 > + git clean --force -x -d --exclude=WebKitBuild I used to try this, but it slams the EBS volumes too much.
Eric Seidel (no email)
Comment 5 2011-05-10 14:16:40 PDT
(In reply to comment #4) > (From update of attachment 93005 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=93005&action=review > > > Tools/EWSTools/start-queue.sh:61 > > + git clean --force -x -d --exclude=WebKitBuild > > I used to try this, but it slams the EBS volumes too much. What do you mean by that?
Eric Seidel (no email)
Comment 6 2011-05-10 14:18:36 PDT
Created attachment 93007 [details] now ignoring chromium gclient content too
Tony Chang
Comment 7 2011-05-10 14:18:51 PDT
(In reply to comment #3) > The only problem with this patch as written is that it will remove all the gclient directories for Chromium. I'm not sure if that matters or not. It might slow down the chromium EWSes more than we want. I could add another --exclude line which ignores Source/WebKit/chromium Doesn't git clean ignore the directories in .gitignore, which includes the gclient pulled directories?
Eric Seidel (no email)
Comment 8 2011-05-10 14:19:24 PDT
git clean does, unless you pass -x. :)
Adam Barth
Comment 9 2011-05-10 14:30:30 PDT
Comment on attachment 93007 [details] now ignoring chromium gclient content too View in context: https://bugs.webkit.org/attachment.cgi?id=93007&action=review > Tools/EWSTools/start-queue.sh:63 > + git clean --force -x -d --exclude=WebKitBuild --exclude=Source/WebKit/chromium We should just use find . -name "*.pyc" | xargs rm to start with. If we need to do mores we can revise. -f -x -d is too big a hammer.
Eric Seidel (no email)
Comment 10 2011-05-10 16:45:19 PDT
I think I tried to do too much in one patch. I'll post a patch which has no functional changes besides the watchdog.
Eric Seidel (no email)
Comment 11 2011-05-10 17:16:44 PDT
Adam Barth
Comment 12 2011-05-10 18:38:14 PDT
Looks fine, but the changelog isn't right anymore.
Eric Seidel (no email)
Comment 13 2011-05-10 22:32:23 PDT
Note You need to log in before you can comment on or make changes to this bug.