Bug 60579 – EWS bots should be robust against test-webkitpy hangs

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

EWS bots should be robust against test-webkitpy hangs

[Eric Seidel (no email)]

Created attachment 93003 [details]
Patch

[Eric Seidel (no email)]

Created attachment 93005 [details]
updated changelog

[Eric Seidel (no email)]

The only problem with this patch as written is that it will remove all the gclient directories for Chromium.  I'm not sure if that matters or not.  It might slow down the chromium EWSes more than we want.  I could add another --exclude line which ignores Source/WebKit/chromium

[Adam Barth]

Comment on attachment 93005 [details]
updated changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=93005&action=review

> Tools/EWSTools/start-queue.sh:61
> +  git clean --force -x -d --exclude=WebKitBuild

I used to try this, but it slams the EBS volumes too much.

[Eric Seidel (no email)]

(In reply to comment #4)
> (From update of attachment 93005 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=93005&action=review
> 
> > Tools/EWSTools/start-queue.sh:61
> > +  git clean --force -x -d --exclude=WebKitBuild
> 
> I used to try this, but it slams the EBS volumes too much.

What do you mean by that?

[Eric Seidel (no email)]

Created attachment 93007 [details]
now ignoring chromium gclient content too

[Tony Chang]

(In reply to comment #3)
> The only problem with this patch as written is that it will remove all the gclient directories for Chromium.  I'm not sure if that matters or not.  It might slow down the chromium EWSes more than we want.  I could add another --exclude line which ignores Source/WebKit/chromium

Doesn't git clean ignore the directories in .gitignore, which includes the gclient pulled directories?

[Eric Seidel (no email)]

git clean does, unless you pass -x. :)

[Adam Barth]

Comment on attachment 93007 [details]
now ignoring chromium gclient content too

View in context: https://bugs.webkit.org/attachment.cgi?id=93007&action=review

> Tools/EWSTools/start-queue.sh:63
> +  git clean --force -x -d --exclude=WebKitBuild --exclude=Source/WebKit/chromium

We should just use

find . -name "*.pyc" | xargs rm

to start with.  If we need to do mores we can revise.  -f -x -d is too big a hammer.

[Eric Seidel (no email)]

I think I tried to do too much in one patch.  I'll post a patch which has no functional changes besides the watchdog.

[Eric Seidel (no email)]

Created attachment 93053 [details]
Patch

[Adam Barth]

Looks fine, but the changelog isn't right anymore.

[Eric Seidel (no email)]

Committed r86213: <http://trac.webkit.org/changeset/86213>