RESOLVED WONTFIX 60577
Move webkitVisibility properties and events to window from document
https://bugs.webkit.org/show_bug.cgi?id=60577
Summary Move webkitVisibility properties and events to window from document
Shishir Agrawal
Reported 2011-05-10 13:41:36 PDT
As per the discussion on the webperf mailing list, we want to have the webkit visibility properties as a window property rather than that of a document.
Attachments
Patch (19.22 KB, patch)
2011-05-10 13:45 PDT, Shishir Agrawal
tonyg: review-
Shishir Agrawal
Comment 1 2011-05-10 13:45:44 PDT
Eric Seidel (no email)
Comment 2 2011-05-10 22:23:37 PDT
You should CC whoever has been reviewing your other visibility patches. Also, you should announce this new feature on webkit-dev per our new feature guidelines: http://www.webkit.org/coding/adding-features.html
Tony Gentilcore
Comment 3 2011-05-11 04:33:39 PDT
(In reply to comment #2) > You should CC whoever has been reviewing your other visibility patches. Also, you should announce this new feature on webkit-dev per our new feature guidelines: > http://www.webkit.org/coding/adding-features.html Eric, here's the thread: https://lists.webkit.org/pipermail/webkit-dev/2011-March/016162.html Shishir, Now that it is landing and an editor's draft spec is available, it might be worth updating the thread. http://w3c-test.org/webperf/specs/PageVisibility/
Tony Gentilcore
Comment 4 2011-05-11 04:38:45 PDT
Comment on attachment 93002 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93002&action=review > LayoutTests/ChangeLog:5 > + Move webkitVisibility properties and events to window from document The thread about this doesn't seem to be resolved. In particular, it looks like Alex is still pushing for document. http://lists.w3.org/Archives/Public/public-web-perf/2011May/0045.html Is there some other information I missed?
Alexey Proskuryakov
Comment 5 2011-05-11 09:12:45 PDT
Yes, "isVisible" is such a short and generic name that adding it to global scope seems questionable. It won't always have the WebKit prefix.
Tony Gentilcore
Comment 6 2011-05-13 06:23:32 PDT
Comment on attachment 93002 [details] Patch Based on comments in the web-perf thread, it looks like this won't be moved. r- to clear it from the review queue. Please reopen if necessary.
Shishir Agrawal
Comment 7 2011-05-24 14:43:41 PDT
As per discussions, this is no longer required. Closing.
Note You need to log in before you can comment on or make changes to this bug.