pos is not a good name, position or location would be far better... My vote is for "location()"
location() seems to match what IntRect uses.
Created attachment 93187 [details] Patch
Comment on attachment 93187 [details] Patch LGTM.
Comment on attachment 93187 [details] Patch Attachment 93187 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8688475
I <3 EWS.
Created attachment 93203 [details] Patch
Comment on attachment 93203 [details] Patch OK.
Comment on attachment 93203 [details] Patch Rejecting attachment 93203 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1 Last 500 characters of output: autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://queues.webkit.org/results/8687523
Thanks for restarting it.
Comment on attachment 93203 [details] Patch Clearing flags on attachment: 93203 Committed r86312: <http://trac.webkit.org/changeset/86312>
All reviewed patches have been landed. Closing bug.
http://trac.webkit.org/changeset/86312 might have broken Chromium Win Release
Comment on attachment 93203 [details] Patch Given the function is used in only 6 places, I think we would have been better off removing it entirely. It seems unnecessary to have helper functions that return pieces of the frameRect.