Bug 60548 - [Chromium] Add rebaselines for video-layer-crash.
Summary: [Chromium] Add rebaselines for video-layer-crash.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: imasaki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-10 06:44 PDT by imasaki
Modified: 2011-05-10 11:48 PDT (History)
7 users (show)

See Also:


Attachments
Patch (465.21 KB, patch)
2011-05-10 06:46 PDT, imasaki
no flags Details | Formatted Diff | Diff
Patch (465.24 KB, patch)
2011-05-10 10:34 PDT, imasaki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description imasaki 2011-05-10 06:44:33 PDT
[Chromium] Add rebaselines for video-layer-crash.
Comment 1 imasaki 2011-05-10 06:46:51 PDT
Created attachment 92948 [details]
Patch
Comment 2 David Levin 2011-05-10 09:51:49 PDT
Comment on attachment 92948 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92948&action=review

> LayoutTests/ChangeLog:9
> +        failing for a long time so rebaselines are necessary. We

Sorry, this explanation doesn't make sense to me. There are a lot of tests that have been failing for a long time but we shouldn't just rebaseline them. Perhaps, you just meant to say that the image needs to be updated because it is incorrect (but the reason why this change happened isn't easily determined at present because the test has been broken for so long).

Is the new baseline correct? (It looks like there isn't much difference from the old image so it probably is.)
Comment 3 imasaki 2011-05-10 10:34:53 PDT
Created attachment 92976 [details]
Patch
Comment 4 WebKit Commit Bot 2011-05-10 11:04:46 PDT
Comment on attachment 92976 [details]
Patch

Clearing flags on attachment: 92976

Committed r86170: <http://trac.webkit.org/changeset/86170>
Comment 5 WebKit Commit Bot 2011-05-10 11:04:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2011-05-10 11:48:14 PDT
http://trac.webkit.org/changeset/86170 might have broken WinCairo Debug (Build)