Bug 60531 - WebKit2: Cancelling full screen before animation completes leads to full screen window staying up.
Summary: WebKit2: Cancelling full screen before animation completes leads to full scre...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-05-09 21:45 PDT by Jer Noble
Modified: 2011-05-10 15:43 PDT (History)
0 users

See Also:

Attachments
Patch (4.95 KB, patch)
2011-05-09 21:52 PDT, Jer Noble 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-05-09 21:45:24 PDT 
WebKit2: Cancelling full screen before animation completes leads to full screen window staying up
Comment 1 Jer Noble 2011-05-09 21:46:34 PDT 
If the user cancels full screen mode before the enter full screen animation completes, Safari leaves the full screen window up containing the (non-full screen) page content.
Comment 2 Jer Noble 2011-05-09 21:51:30 PDT 
<rdar://problem/9411473>
Comment 3 Jer Noble 2011-05-09 21:52:32 PDT 
Created attachment 92915 [details]
Patch
Comment 4 Darin Adler 2011-05-10 08:51:15 PDT 
Comment on attachment 92915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=92915&action=review

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:-322
>      
> -    _isAnimating = NO;

Should remove this excess blank line too.
Comment 5 Jer Noble 2011-05-10 15:41:08 PDT 
(In reply to comment #4)
> (From update of attachment 92915 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92915&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:-322
> >      
> > -    _isAnimating = NO;
> 
> Should remove this excess blank line too.

Will do.  Thanks!
Comment 6 Jer Noble 2011-05-10 15:43:37 PDT 
Committed r86186: <http://trac.webkit.org/changeset/86186>