WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
60531
WebKit2: Cancelling full screen before animation completes leads to full screen window staying up.
https://bugs.webkit.org/show_bug.cgi?id=60531
Summary
WebKit2: Cancelling full screen before animation completes leads to full scre...
Jer Noble
Reported
2011-05-09 21:45:24 PDT
WebKit2: Cancelling full screen before animation completes leads to full screen window staying up
Attachments
Patch
(4.95 KB, patch)
2011-05-09 21:52 PDT
,
Jer Noble
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jer Noble
Comment 1
2011-05-09 21:46:34 PDT
If the user cancels full screen mode before the enter full screen animation completes, Safari leaves the full screen window up containing the (non-full screen) page content.
Jer Noble
Comment 2
2011-05-09 21:51:30 PDT
<
rdar://problem/9411473
>
Jer Noble
Comment 3
2011-05-09 21:52:32 PDT
Created
attachment 92915
[details]
Patch
Darin Adler
Comment 4
2011-05-10 08:51:15 PDT
Comment on
attachment 92915
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=92915&action=review
> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:-322 > > - _isAnimating = NO;
Should remove this excess blank line too.
Jer Noble
Comment 5
2011-05-10 15:41:08 PDT
(In reply to
comment #4
)
> (From update of
attachment 92915
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=92915&action=review
> > > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:-322 > > > > - _isAnimating = NO; > > Should remove this excess blank line too.
Will do. Thanks!
Jer Noble
Comment 6
2011-05-10 15:43:37 PDT
Committed
r86186
: <
http://trac.webkit.org/changeset/86186
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug