RESOLVED INVALID 60530
Fix wincairo build broken due to gtest 
https://bugs.webkit.org/show_bug.cgi?id=60530
Summary Fix wincairo build broken due to gtest
Dmitry Lomov
Reported 2011-05-09 21:44:20 PDT
wincairo build has been broken due to addition of gtest
Attachments
Fixing build (55.26 KB, patch)
2011-05-09 21:53 PDT, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Gor rid of bogus line terminator changes (41.68 KB, patch)
2011-05-09 22:09 PDT, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dmitry Lomov
Comment 1 2011-05-09 21:53:28 PDT
Created attachment 92916 [details] Fixing build
WebKit Review Bot
Comment 2 2011-05-09 21:56:29 PDT
Attachment 92916 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/ThirdParty/gtest/msvc..." exit_code: 1 Source/WebKit/win/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dmitry Lomov
Comment 3 2011-05-09 22:09:55 PDT
Created attachment 92918 [details] Gor rid of bogus line terminator changes
David Levin
Comment 4 2011-05-10 12:52:26 PDT
Comment on attachment 92918 [details] Gor rid of bogus line terminator changes Will be part of the bigger patch now (since the orig patch was rolled out).
Note You need to log in before you can comment on or make changes to this bug.