Bug 60530 - Fix wincairo build broken due to gtest
Summary: Fix wincairo build broken due to gtest
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-09 21:44 PDT by Dmitry Lomov
Modified: 2011-05-10 12:52 PDT (History)
4 users (show)

See Also:

Attachments
Fixing build (55.26 KB, patch)
2011-05-09 21:53 PDT, Dmitry Lomov 		no flags Details | Formatted Diff | Diff
Gor rid of bogus line terminator changes (41.68 KB, patch)
2011-05-09 22:09 PDT, Dmitry Lomov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Lomov 2011-05-09 21:44:20 PDT 
wincairo build has been broken due to addition of gtest
Comment 1 Dmitry Lomov 2011-05-09 21:53:28 PDT 
Created attachment 92916 [details]
Fixing build
Comment 2 WebKit Review Bot 2011-05-09 21:56:29 PDT 
Attachment 92916 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/ThirdParty/gtest/msvc..." exit_code: 1

Source/WebKit/win/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dmitry Lomov 2011-05-09 22:09:55 PDT 
Created attachment 92918 [details]
Gor rid of bogus line terminator changes
Comment 4 David Levin 2011-05-10 12:52:26 PDT 
Comment on attachment 92918 [details]
Gor rid of bogus line terminator changes

Will be part of the bigger patch now (since the orig patch was rolled out).