Bug 60513 - [Qt] QtRawFont support should check based on feature, not version
Summary: [Qt] QtRawFont support should check based on feature, not version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P4 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-09 15:56 PDT by Keith Kyzivat
Modified: 2011-05-10 08:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2011-05-09 15:59 PDT, Keith Kyzivat 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Kyzivat 2011-05-09 15:56:44 PDT 
Recent support added for QtRawFont should be done based on feature, not on Qt version.

Changeset introducing error: http://trac.webkit.org/changeset/86054
Comment 1 Keith Kyzivat 2011-05-09 15:59:44 PDT 
Created attachment 92874 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2011-05-10 02:27:16 PDT 
Comment on attachment 92874 [details]
Patch

Looks ok though im no build genius
Comment 3 WebKit Commit Bot 2011-05-10 04:24:54 PDT 
Comment on attachment 92874 [details]
Patch

Clearing flags on attachment: 92874

Committed r86140: <http://trac.webkit.org/changeset/86140>
Comment 4 WebKit Commit Bot 2011-05-10 04:24:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2011-05-10 04:58:22 PDT 
The commit-queue encountered the following flaky tests while processing attachment 92874 [details]:

http/tests/inspector/console-websocket-error.html bug 57392 (authors: pfeldman@chromium.org and yutak@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 Ademar Reis 2011-05-10 08:16:43 PDT 
Revision r86140 cherry-picked into qtwebkit-2.2 with commit 30757bc <http://gitorious.org/webkit/qtwebkit/commit/30757bc>