Bug 60502 - Enable strict PassOwnPtr on Chromium
Summary: Enable strict PassOwnPtr on Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-09 14:14 PDT by Adam Barth
Modified: 2011-05-10 22:55 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.07 KB, patch)
2011-05-09 14:18 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2011-05-09 15:41 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (2.23 KB, patch)
2011-05-09 16:02 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (3.14 KB, patch)
2011-05-09 16:21 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (5.04 KB, patch)
2011-05-09 17:56 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (1.02 KB, patch)
2011-05-10 14:55 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-05-09 14:14:31 PDT 
Enable strict PassOwnPtr on Chromium
Comment 1 Adam Barth 2011-05-09 14:18:57 PDT 
Created attachment 92849 [details]
Patch
Comment 2 WebKit Review Bot 2011-05-09 14:59:44 PDT 
Comment on attachment 92849 [details]
Patch

Attachment 92849 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8646697
Comment 3 Adam Barth 2011-05-09 15:41:43 PDT 
Created attachment 92868 [details]
Patch
Comment 4 David Levin 2011-05-09 15:46:50 PDT 
If you meant to do r?, r=me on that patch as well.
Comment 5 Adam Barth 2011-05-09 15:56:58 PDT 
(In reply to comment #4)
> If you meant to do r?, r=me on that patch as well.

I'm going to try iterating on this patch for a bit to see if it's hopeless to do without a real linux box.
Comment 6 Adam Barth 2011-05-09 16:02:01 PDT 
Created attachment 92875 [details]
Patch
Comment 7 Adam Barth 2011-05-09 16:21:26 PDT 
Created attachment 92880 [details]
Patch
Comment 8 Adam Barth 2011-05-09 17:56:23 PDT 
Created attachment 92896 [details]
Patch
Comment 9 Adam Barth 2011-05-10 00:50:54 PDT 
Comment on attachment 92896 [details]
Patch

This is ready for commit, but it might cause trouble on landing.  I'll need to watch the tree when this lands.
Comment 10 Adam Barth 2011-05-10 14:53:36 PDT 
Committed r86182: <http://trac.webkit.org/changeset/86182>
Comment 11 Adam Barth 2011-05-10 14:55:19 PDT 
Created attachment 93014 [details]
Patch
Comment 12 Adam Barth 2011-05-10 22:21:23 PDT 
Comment on attachment 93014 [details]
Patch

Clearing flags on attachment: 93014

Committed r86211: <http://trac.webkit.org/changeset/86211>
Comment 13 Adam Barth 2011-05-10 22:21:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 14 WebKit Review Bot 2011-05-10 22:55:12 PDT 
http://trac.webkit.org/changeset/86211 might have broken Chromium Win Release